Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are we running clang-format both in lintrunner and in the clang-format job? #141

Closed
zasdfgbnm opened this issue Apr 5, 2023 · 0 comments · Fixed by #406
Closed

Are we running clang-format both in lintrunner and in the clang-format job? #141

zasdfgbnm opened this issue Apr 5, 2023 · 0 comments · Fixed by #406

Comments

@zasdfgbnm
Copy link
Collaborator

I saw two failures, one in lintrunner, the other in clang-format when one of my file was not formatted. I don't think it is a problem as clang-format is pretty fast. Just feel a bit weird about having this duplication. We may probably consider removing

clang-format:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
submodules: true
- uses: actions/setup-python@v4
with:
python-version: '3.10'
- name: Install clang-format
run: pip install clang-format==12.0.1.2
- name: Run clang-format
working-directory: ${{ env.working_directory }}
run: |
find ./csrc -regex '.*\.\(cpp\|hpp\|cu\|c\|h\)' -exec clang-format -style=file -i {} \;
find ./test -regex '.*\.\(cpp\|hpp\|cu\|c\|h\)' -exec clang-format -style=file -i {} \;
find ./benchmark -regex '.*\.\(cpp\|hpp\|cu\|c\|h\)' -exec clang-format -style=file -i {} \;
find ./runtime -regex '.*\.\(cpp\|hpp\|cu\|c\|h\)' -exec clang-format -style=file -i {} \;
git --no-pager diff --exit-code

zasdfgbnm added a commit that referenced this issue May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant