Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime check for circular buffer correctness #2699

Closed
rdspring1 opened this issue Jul 26, 2024 · 0 comments · Fixed by #2703
Closed

Add runtime check for circular buffer correctness #2699

rdspring1 opened this issue Jul 26, 2024 · 0 comments · Fixed by #2703

Comments

@rdspring1
Copy link
Collaborator

We generate incorrect results if the size of the pipeline is greater than the size of the circular buffering for-loop.

For example, say that the pipeline size is 4 and circular buffering loop size is 2.
prologue loop is (0, S-1) => (0, 3)
main loop is (0, N-(S-1)) => (0, -1)
epilogue loop is (N-(S-1), N) => (-1, 2)

The proposed fix is to have a runtime check to determine that the entire pipeline is filled at least once.

rdspring1 added a commit that referenced this issue Jul 27, 2024
This PR adds a parameterized test suite for circular buffering. It is
used to test a range of buffers from 2 to 4.

TODO: Add a runtime check to ensure that entire pipeline is filled by
given inputs. See #2699.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant