Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueError when higher minimum_timestamp_duration given : "start_time must be a float or str containing float, but got int" #8592

Closed
Stephane-Lpt opened this issue Mar 5, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Stephane-Lpt
Copy link
Contributor

Stephane-Lpt commented Mar 5, 2024

Describe the bug
I wanted to put a minimum_timestamp_duration to visualize the result given by nemo forced aligner with Gecko as the documentation recommends.
When I change the value of minimum_timestamp_duration to 0.4, it's all good.
If I try to change the minimum_timestamp_duration for a higher value like 0.5, I get a ValueError :
image
Steps/Code to reproduce bug

  • Notice the option ctm_file_config.minimum_timestamp_duration=0.5 to change the value of minimum_timestamp_duration. To be sure to have the error, you can put an extremely high value like 50.
python <path to NeMo>/tools/nemo_forced_aligner/align.py pretrained_name="stt_en_fastconformer_hybrid_large_pc" manifest_filepath=nemo/manifest.json output_dir=nemo/output ctm_file_config.minimum_timestamp_duration=0.5

The value that is too high and causes the error depends on the respective duration of your tokens/words/segments that are calculated in this loop. The loop iterates over each token/word/segment of the transcription and finally produces the ctm file).

Expected behavior

  • No error should be raised.

Environment overview

  • Method of NeMo install: source

Additional context
This is a minor error that I've already fixed locally, so I'll make a pull request in a few minutes

@Stephane-Lpt Stephane-Lpt added the bug Something isn't working label Mar 5, 2024
@erastorgueva-nv
Copy link
Collaborator

PR with fix has been merged, so closing this. Thank you for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants