add birth_date and death_date properties to Worker #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @marklap, I know this feature is trivial, but can you provide some tests for the two properties? |
|
Can do. Standby... |
1 similar comment
|
Added two tests to test_worker.py. Is this adequate? |
| self.assertEquals(type(birth_date).__name__, 'datetime') | ||
|
|
||
| def test_worker_sets_death(self): | ||
| """Ensure worker correctly sets worker birth date.""" |
There was a problem hiding this comment.
There's a typo here. Should be Ensure worker correctly sets worker birth date.
|
Think this covers everything |
selwin
added a commit
that referenced
this pull request
Feb 27, 2015
add birth_date and death_date properties to Worker
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed a LONG time ago in #252
Add birth and death properties to Worker