Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with recent updates #32

Closed
kkharji opened this issue Dec 9, 2020 · 2 comments
Closed

Issues with recent updates #32

kkharji opened this issue Dec 9, 2020 · 2 comments

Comments

@kkharji
Copy link
Contributor

kkharji commented Dec 9, 2020

Hey @tjdevries awesome work. I like the new commands very useful.

  • PlenaryBustedFile tests/plenary/curl_spec.lua exit neovim but ran tests okay
  • PlenaryBustedDirectory tests/plenary unlike the above, opens popup but has escape codes all over. that I'm sure requires external plugin in order to fix that, but that is annoying extra work for the user. Also it doesn't auto scroll when new results get printed.

For now PlenaryBustedDirectory to a file works okay and opens popup.

@matu3ba
Copy link
Contributor

matu3ba commented Oct 3, 2021

@tami5 I reproduce your problems with both tests, when I run them in the in-build terminal from neovim.
Running tests with :!make sounds like a bad idea to me, since you will not see where the test has failed.

Suggestion to close.

@Conni2461
Copy link
Collaborator

These issues actually existed back in the day. We fixed it and i just forgot to close it 😆

Thanks for bumping it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants