Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "scrolling" through results in the list. #42

Closed
rockerBOO opened this issue Sep 8, 2020 · 15 comments
Closed

Allow "scrolling" through results in the list. #42

rockerBOO opened this issue Sep 8, 2020 · 15 comments
Labels
Feature Request A request for a new feature or capabilities for telescope

Comments

@rockerBOO
Copy link
Member

Right now you are limited to the results in the list.

If I am on vertical I am only showing 8 results by default.

I sometimes use the fuzzy to give me a short list to browse through.

Solutions

Allow us to go up on the list beyond the presented list.

I think limiting the the total results would be fine. 100 total results available for instance. Unless we want to encourage fuzzy browsing which then no limit (high limit) might be good.

@clason
Copy link
Contributor

clason commented Sep 8, 2020

You know, until now I didn't realize that you couldn't scroll through the results list...

(I think I'd rather do lazy loading, i.e., if you scroll to the top-most result, retrigger the search with the current typed pattern and cut off at 2*results.height.)

@tjdevries
Copy link
Member

Yes, it's a good idea. It might require a bit of time to think about. I have implemented lines_manager to (potentially) be able to handle this kind of thing at some point in the future.

I think maybe first step would be:

  1. make it so that we can have top->down or down->top results sorting. This will require me to find all the places I have ssumptions about lines and sorting spots.
  2. then, after doing that, we should be able to do some tricks to just move past the visible area.

@rockerBOO rockerBOO added the enhancement Enhancement to performance, inner workings or existent features label Oct 4, 2020
@kkharji kkharji added Feature Request A request for a new feature or capabilities for telescope and removed enhancement Enhancement to performance, inner workings or existent features labels Nov 17, 2020
@kkharji
Copy link
Member

kkharji commented Nov 17, 2020

I'm starting to use loclist to get tags (from markdown into location) and use it as an outline. This feature is really useful

@tjdevries tjdevries modified the milestones: 2., 2.0 Jan 11, 2021
@mizlan
Copy link

mizlan commented Apr 1, 2021

Yes, it's a good idea. It might require a bit of time to think about. I have implemented lines_manager to (potentially) be able to handle this kind of thing at some point in the future.

@tjdevries Where can I find lines_manager? Is it on a particular branch or fork?

@apazzolini
Copy link

Until this feature is built, are the full results accessible programmatically?

Specifically, I'd like to be able to trigger live_grep and send all results (including the ones outside the visible range) to the quickfix list.

@VVKot
Copy link
Contributor

VVKot commented Apr 18, 2021

@apazzolini you can do exactly that with <C-q>

["<C-q>"] = actions.send_to_qflist + actions.open_qflist,

@apazzolini
Copy link

actions.send_to_qflist + actions.open_qflist

Oh, I didn't realize that sent invisible results as well. Thanks!

@VVKot
Copy link
Contributor

VVKot commented Apr 18, 2021

You're welcome. I remembered that I actually use smart_send_to_qflist instead, which sends all results if there is no selection - but only selected rows if there is. Check it out!

@finviman
Copy link

finviman commented Jun 6, 2021

yes, this feature is highly wanted, i leave a comment in order to be notified at the first time.

@VVKot
Copy link
Contributor

VVKot commented Jun 6, 2021

@FinallyFinancialFreedom // whoever else who wants to subscribe to issues, there is a subscribe button on the right you can click without a need to comment:

Screenshot 2021-06-06 at 05 34 09

@tjdevries
Copy link
Member

+1

@her
Copy link

her commented Aug 24, 2021

@tjdevries add a bounty to it? :)

@tjdevries
Copy link
Member

Haha, well it's on the todo list. I completed step one which was asyncify more of the Ui. This is one of the next steps.

@tjdevries
Copy link
Member

I don't know what the easiest way to set up bounty or fundraiser is

@rockerBOO
Copy link
Member Author

This is now working up to 1000 results with #1232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request A request for a new feature or capabilities for telescope
Projects
None yet
Development

No branches or pull requests

9 participants