Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom highlight group for selection in finder #41

Closed
weilbith opened this issue Jan 29, 2021 · 2 comments · Fixed by #42
Closed

Use custom highlight group for selection in finder #41

weilbith opened this issue Jan 29, 2021 · 2 comments · Fixed by #42

Comments

@weilbith
Copy link
Contributor

You recently added the ability to change colors to highlight the current active entry in the finder. This is configured by two color values. I think it would be cool if you would add a new custom highlight group and then link the cursor line to this group. This still allows the user to easily change the highlight. But instead of defining raw color values you could also create a highlight link. So for example would I link it to the Search highlight group of my theme. But now I need to copy paste the colors. And I can't even apply "effects" like bold text. And now if I change my theme, I must also change the colors here again...
Would be a cool addition.


Btw: your recent improvements on the finder window are great! 💪

@weilbith weilbith changed the title Use custom highlight group for selection highlight Use custom highlight group for selection in finder Jan 29, 2021
@weilbith
Copy link
Contributor Author

Or just say you agree with the solution and I quickly do it so you can focus on what you intended to do else.

@glepnir
Copy link
Member

glepnir commented Jan 29, 2021

pr,welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants