-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing src reference in the gulpfile.js #67
Comments
I have fixed this in my fork, and want to do a Pull Request, but the Pull Request is trying to incorporate the previous changes I have in another pending Pull Request. How do I do a Pull Request for a single commit? |
@sholman thank you for reporting this. We will look into it as soon as possible and circle back to you. As far as pull requests go, you would need to create a branch in your repo for each issue you would like submit a PR for. That way, only the relevant changes are included. We follow a model of branch names like |
@tksheppard this does appear to be a bug. Can you confirm? |
Indeed it is a bug. It's a leftover relic from one of the original iterations. Nice catch @sholman! |
Describe the bug
The images task in the gulpfile.js uses the following reference ('./images/**/*.{jpg,jpeg,png,gif}') which is inconsistent with the convention of storing source files in the src folder. Any images placed in the src/images folder will be ignored during the build process
This should be updated to ('./'+src+'images/**/*.{jpg,jpeg,png,gif}') to reference the src folder
The text was updated successfully, but these errors were encountered: