Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing src reference in the gulpfile.js #67

Closed
sholman opened this issue Aug 9, 2018 · 4 comments · Fixed by #96
Closed

missing src reference in the gulpfile.js #67

sholman opened this issue Aug 9, 2018 · 4 comments · Fixed by #96
Assignees
Labels
bug Something isn't working

Comments

@sholman
Copy link

sholman commented Aug 9, 2018

Describe the bug

The images task in the gulpfile.js uses the following reference ('./images/**/*.{jpg,jpeg,png,gif}') which is inconsistent with the convention of storing source files in the src folder. Any images placed in the src/images folder will be ignored during the build process

This should be updated to ('./'+src+'images/**/*.{jpg,jpeg,png,gif}') to reference the src folder

@sholman
Copy link
Author

sholman commented Aug 9, 2018

I have fixed this in my fork, and want to do a Pull Request, but the Pull Request is trying to incorporate the previous changes I have in another pending Pull Request. How do I do a Pull Request for a single commit?

@david-poindexter
Copy link
Member

david-poindexter commented Aug 9, 2018

@sholman thank you for reporting this. We will look into it as soon as possible and circle back to you.

As far as pull requests go, you would need to create a branch in your repo for each issue you would like submit a PR for. That way, only the relevant changes are included. We follow a model of branch names like issue-##. This keeps things nice and clean.

@david-poindexter david-poindexter added the bug Something isn't working label Aug 9, 2018
@david-poindexter
Copy link
Member

@tksheppard this does appear to be a bug. Can you confirm?

@tksheppard
Copy link
Collaborator

Indeed it is a bug. It's a leftover relic from one of the original iterations. Nice catch @sholman!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants