Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Materials for OBJ #43

Open
bboudaoud-nv opened this issue Jul 18, 2019 · 2 comments
Open

Setting Materials for OBJ #43

bboudaoud-nv opened this issue Jul 18, 2019 · 2 comments
Assignees
Labels
defer Defer working on this for a future date/request

Comments

@bboudaoud-nv
Copy link
Collaborator

The amPose->materialTable.set() calls in App.cpp uses an explicit OBJ name (core/icosahedron_default). This is a problem if we want to allow the new target defined modelSpec to use OBJs without this internal name. For now our new cylinder model just uses this name internally. In the future it would be good to get this OBJ name rather than hard-coding it if possible.

@jspjutNV
Copy link
Contributor

If we keep following our current method of having models that include a flipped border geometry outside, we are probably okay having a specific object mesh/material designed to be the object and another designed to be the silhouette. Since we started with a icosahedron target, core/icosahedron_default was the material, but we could go in and change that to a more logical name like core/core or something.

I suggest we de-prioritize this fix until someone needs a wide variety of different target models since that would give us more information about how much we'd be able to modify the .objs vs. just use .objs made by someone else without modification.

@bboudaoud-nv
Copy link
Collaborator Author

I agree that this is not a high priority considering our (somewhat unique) approach to winding-order based geometry, I also agree that we should move to a more generic name (maybe core/target?). If you'd like we can keep this issue around as a reminder to transition to a more generic name.

@bboudaoud-nv bboudaoud-nv added the defer Defer working on this for a future date/request label Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defer Defer working on this for a future date/request
Projects
None yet
Development

No branches or pull requests

2 participants