Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong output #7

Closed
JonathanLehner opened this issue Aug 2, 2022 · 26 comments
Closed

wrong output #7

JonathanLehner opened this issue Aug 2, 2022 · 26 comments

Comments

@JonathanLehner
Copy link
Contributor

I cloned the repository and followed the installation instructions but the output is wrong
Screenshot from pexels-walking-dynamic-5738706_seed1_sbs_all mp4

@Khrylx
Copy link
Collaborator

Khrylx commented Aug 2, 2022

The mesh visualization you are using seems different from what the demo uses.

Do the examples in readme work?

python global_recon/run_demo.py --cfg glamr_dynamic \
                                --video_path assets/dynamic/running.mp4 \
                                --out_dir out/glamr_dynamic/running \
                                --save_video

@JonathanLehner
Copy link
Contributor Author

no, the output is from the example in the readme. It also does not work for the running scene. The output looks similar. Is there a specific python version? I used 3.8. Or are there additional installation requirements for the visualisation to work correctly? HybrIK works without problems.

@Khrylx
Copy link
Collaborator

Khrylx commented Aug 2, 2022

could you try these commands and try rendering again?

# mesa
sudo apt update
sudo wget https://github.com/mmatl/travis_debs/raw/master/xenial/mesa_18.3.3-0.deb
sudo dpkg -i ./mesa_18.3.3-0.deb || true
sudo apt install -f

@Khrylx
Copy link
Collaborator

Khrylx commented Aug 2, 2022

If this doesn't solve it, it might due to problems with the visualization package pyvista.
Could you try its example here: https://docs.pyvista.org/examples/02-plot/gif.html?highlight=off_screen?

@JonathanLehner
Copy link
Contributor Author

Hi Yeyuan, thanks for your fast reply! I tried mesa but it did not help. I used pyvista 3.3 since not fixed in requirements, but also no difference.

The strange thing is that the demo in HybrIK works and in GLAMR the HybrIK output already is shifted. Could it be that there were breaking changes in the official HybrIK repo? It was updated recently

@Khrylx
Copy link
Collaborator

Khrylx commented Aug 3, 2022

That's strange. Could you try my fork of HybrIK https://github.com/Khrylx/HybrIK?

@haofanwang
Copy link
Contributor

haofanwang commented Aug 8, 2022

I have met the same problem. The HybrIK result is already bad, and GLAMR works worse.

Here is the image saved in ./out/glamr_dynamic/running/pose_est/res_images/000089.jpg

000089

This is my result
截屏2022-08-08 20 59 52

@Khrylx
Copy link
Collaborator

Khrylx commented Aug 8, 2022

@haofanwang Could you try my fork of HybrIK? https://github.com/Khrylx/HybrIK

@haofanwang
Copy link
Contributor

haofanwang commented Aug 8, 2022

Hi, @Khrylx

It seems not to be the problem of update in HybrIK, but ./pose_est/hybrik_demo/demo.py.

If I comment out line 169-171, the visualization works fine. These lines are not existed in HybrIK. I'm not sure whether it is necessary in your method.

new_princpt = np.array([image.shape[1], image.shape[0]]) * 0.5

Besides, the following line should be bbox_3d_shape=(2.2, 2.2, 2.2), which should be a typo.

bbox_3d_shape=(2.2, 2,2, 2.2),

@Khrylx
Copy link
Collaborator

Khrylx commented Aug 8, 2022

These lines are needed to move the camera coordinate from the bounding box center to the image center. I will also look into it.

@haofanwang
Copy link
Contributor

Indeed, the modification above still does not work. Below is my current result for reference. Removing line 169-171 makes HybrIK right, but not the GLAMR.

截屏2022-08-08 21 52 06

@Khrylx
Copy link
Collaborator

Khrylx commented Aug 8, 2022

@haofanwang if you don't make the change, does the demo work for basketball.mp4?

@Khrylx
Copy link
Collaborator

Khrylx commented Aug 8, 2022

I have pushed a fix. At least on my end, both running.mp4 and basketball.mp4 work well. @haofanwang, also make sure for running you are using the dynamic config, which could be the reason for your wrong output.

python global_recon/run_demo.py --cfg glamr_dynamic \
                                --video_path assets/dynamic/running.mp4 \
                                --out_dir out/glamr_dynamic/running \
                                --save_video

@haofanwang
Copy link
Contributor

Still stuck. The GLAMR fits at the first frame, but shifts later.

截屏2022-08-09 00 26 45

basketball.mp4 also doesn't work well. At the first frame, it looks fine, but all following frames keep same as the first one.
截屏2022-08-09 00 33 23

I will also check is there anything I have missed.

@Khrylx
Copy link
Collaborator

Khrylx commented Aug 8, 2022

so you mean the GLAMR's (green) pose remains the same for all the frames? It would be also helpful if you can append your log.txt

@haofanwang
Copy link
Contributor

For static video, yes.

I have uploaded the visualization results and logs to Google Drive.

@Khrylx
Copy link
Collaborator

Khrylx commented Aug 8, 2022

The 2d keypoints look correct, so this is probably just a visualization issue. Could you try pyvista==0.31.3?

pip install pyvista==0.31.3

@haofanwang
Copy link
Contributor

haofanwang commented Aug 8, 2022

It works! Thanks for your patient help! @Khrylx

@Khrylx
Copy link
Collaborator

Khrylx commented Aug 8, 2022

@JonathanLehner could you please try the above fix and let me know whether I can close this issue? thanks!

@JonathanLehner
Copy link
Contributor Author

yes, sorry for delay. My PC has some issues right now..

@Khrylx Khrylx closed this as completed Aug 8, 2022
@arakis92
Copy link

arakis92 commented Aug 9, 2022

Hello, currently I'm having the same issue shared by @JonathanLehner , rendering of glamr is totally black. I've tried with mesa upgrading and pyvista upgrading.

@lucasjinreal
Copy link

I think pyvista only works on a specific version, this is sucks, since pyvista is just a visualization lib. Can we just please move render to pytorch3d?

@iulsko
Copy link

iulsko commented Aug 21, 2022

can attest to the same issue - totally blank GLAMR output!
have tried all the mentioned solutions

@JonathanLehner
Copy link
Contributor Author

I also found I needed to install torchmetrics-0.6.0 for it to run

@JonathanLehner
Copy link
Contributor Author

and downgrade to scipy==1.1.0

@JonathanLehner
Copy link
Contributor Author

I had to upgrade pip to install it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants