Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17. Update User Manual with instructions on how to populate SENSOR_MODEL .nc variable #3

Open
vpaba opened this issue Feb 9, 2023 · 5 comments
Assignees
Labels

Comments

@vpaba
Copy link
Contributor

vpaba commented Feb 9, 2023

Current instructions are that, going forward, new sensor models added to R27/SENSOR_MODEL should not include the manufacturer's name in the label.
We will not be changing the name of existing concepts that contain the manufacturer's name in their label.

@vpaba vpaba transferred this issue from OneArgo/ArgoVocabs Feb 9, 2023
@vpaba vpaba added the admt-23 label Feb 9, 2023
@tcarval
Copy link

tcarval commented Jun 12, 2023

This recommendation is for the NVS editors, not for Argo users.
@vpaba , can we update the R27 description http://vocab.nerc.ac.uk/search_nvs/R27/?searchstr=&options=identifier,preflabel,altlabel,status_accepted&rbaddfilter=inc&searchstr2=

Description Terms describing sensor models in Argo NetCDF arrays
Description Terms describing sensor models in Argo NetCDF arrays. Note: avoid using the manufacturer name in new entries when possible

@vpaba
Copy link
Contributor Author

vpaba commented Jun 12, 2023

Hi @tcarval, @danibodc has kindly made this update, which should be visible on the web interface from tomorrow

@vpaba
Copy link
Contributor Author

vpaba commented Jun 13, 2023

@tcarval on second thought, shall we extend the description to say that firmware version should also not be included in future entries?

Description Terms describing sensor models in Argo NetCDF arrays. Note: avoid using the manufacturer name and firmware version in new entries when possible

@mscanderbeg
Copy link

Glad to see this updated description going into the R27 NVS table. Will the owners, @tcarval @ClareBellingham , @MKrieger29 and @roswri please try and keep this in mind when reviewing new requests for SENSOR_MODEL?

@tcarval
Copy link

tcarval commented Aug 16, 2023

@tcarval on second thought, shall we extend the description to say that firmware version should also not be included in future entries?

There are 11 entries for SBE61 sensor. I guess that each of these firmware version have differences that matter.
So in my opinion, we should keep the firmware in the sensor code. Otherwise, we should manage sensor code + a new firmware code.

SBE61CP_V5.0.1
SBE61
SBE61_V4.5.2
SBE61_V4.5.3
SBE61_V5.0.0
SBE61_V5.0.1
SBE61_V5.0.2
SBE61_V5.0.3
SBE61_V5.0.9
SBE61_V5.0.10
SBE61_V5.0.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

No branches or pull requests

4 participants