Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse thread pool for threaded tests #37

Open
Swatinem opened this issue Dec 4, 2023 · 0 comments · May be fixed by #44
Open

Reuse thread pool for threaded tests #37

Swatinem opened this issue Dec 4, 2023 · 0 comments · May be fixed by #44
Labels
enhancement New feature or request

Comments

@Swatinem
Copy link

Swatinem commented Dec 4, 2023

Being able to run tests multi-threaded simply by adding DIVAN_THREADS=XXX to get a feeling for contention is super nice.
However it seems like every benchmark run is using scoped threads under the hood.

Running a threaded benchmark through samply record, I end up with well beyond 6k "tracks", each of which is extremely short lived and it is pretty much impossible to select any of the background threads to do proper profiling.

It also appears that a large portion of the main thread time is actually spent creating / destroying threads themselves, at least on macOs where I tested this:

Bildschirmfoto 2023-12-04 um 11 09 35
@nvzqz nvzqz added the enhancement New feature or request label Dec 6, 2023
@Swatinem Swatinem linked a pull request Feb 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reuse benchmark threads across runs Swatinem/divan
2 participants
@Swatinem @nvzqz