Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[win] implemented set/get AppUserModelID #47

Open
wants to merge 3 commits into
base: nw18
Choose a base branch
from
Open

[win] implemented set/get AppUserModelID #47

wants to merge 3 commits into from

Conversation

ghostoy
Copy link
Member

@ghostoy ghostoy commented Oct 18, 2016

Exposed the APIs for setting AUMID from native app windows.

chrome-cron and others added 3 commits October 12, 2016 00:39
@ghostoy ghostoy mentioned this pull request Oct 18, 2016
Open
@dobriai
Copy link

dobriai commented Nov 18, 2016

Just a poke: Any developments here?

rogerwang pushed a commit that referenced this pull request Dec 5, 2016
@randomascii
Stub out Skia AVX and HSW opts.
bc63dc1 
This is hopefully temporary while we mull better options.

BUG=666707

Review-Url: https://codereview.chromium.org/2512093003
Cr-Commit-Position: refs/heads/master@{#433407}
(cherry picked from commit 2ea76e2)

Review URL: https://codereview.chromium.org/2519083004 .

Cr-Commit-Position: refs/branch-heads/2924@{#47}
Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
GnorTech pushed a commit that referenced this pull request Jan 29, 2017
[ash-md] Makes sure that minimized windows can be activated in overview
e86ab7d 
When windows are minimized before entering overview mode, they are
replaced with a widget that has mirrored layers. Opacity of the original
window needs to be then set to 1 in order to make it visible
(in WindowMirrorView::InitLayerOwner()).
Upon exiting overview the original window's opacity is restored.
This logic breaks if a window is selected - the opacity need not be
restored (to zero).
Make it so that the opacity is set to 1 upon exit if a window is
selected.

BUG=677177

Review-Url: https://codereview.chromium.org/2637403013
Cr-Commit-Position: refs/heads/master@{#445524}
(cherry picked from commit 8f64e92)

Review-Url: https://codereview.chromium.org/2657453003 .
Cr-Commit-Position: refs/branch-heads/2987@{#47}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang pushed a commit that referenced this pull request Mar 11, 2017
@danbeam
MD Settings: disable by default in M58
e483706 
R=dpapad@chromium.org
BUG=478982
NOPRESUBMIT=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2738723002
Cr-Commit-Position: refs/branch-heads/3029@{#47}
Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech pushed a commit that referenced this pull request Apr 26, 2017
@betasheet
[blink] Request compositing update when canvas hibernates/wakes up.
0009f9a 
Not requesting the update can lead to the canvas not
being shown, as in the bug referenced below.

BUG=708445

Review-Url: https://codereview.chromium.org/2808493002
Cr-Commit-Position: refs/heads/master@{#465206}
(cherry picked from commit 5047940)

Review-Url: https://codereview.chromium.org/2828693002 .
Cr-Commit-Position: refs/branch-heads/3071@{#47}
Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech pushed a commit that referenced this pull request Aug 5, 2017
Revert of Make ProfileIOData use URLRequestContextBuilder (patchset #12…
b090f50 
… id:330001 of https://codereview.chromium.org/2978443002/ )

Reason for revert:
Wasn't thinking when I landed this just before branch.

Original issue's description:
> Make ProfileIOData use URLRequestContextBuilder
>
> BUG=734199
>
> Review-Url: https://codereview.chromium.org/2978443002
> Cr-Commit-Position: refs/heads/master@{#487590}
> Committed: https://chromium.googlesource.com/chromium/src/+/189ddf60b2f4034a2ab6efb16e22ea389b2b779f

TBR=mmenke@chromium.org, rdsmith@chromium.org
BUG=734199,746576#c3

(cherry picked from commit 8636cbd)

Review-Url: https://codereview.chromium.org/2986623002
Cr-Original-Commit-Position: refs/heads/master@{#488562}
Change-Id: Iff1b60065f76c6fad9aea8e82c5fa7a3ff584ebc
Reviewed-on: https://chromium-review.googlesource.com/585894
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#47}
Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech pushed a commit that referenced this pull request Sep 14, 2017
[Home] Change bottom navigation menu.
d16e90b 
Brings visual updates to the bottom navigation menu, by removing labels,
shrinking its height, changing colors, and updating icon spacing
behaviour.

Makes several modifications to the Android support library bottom
navigation menu widget that was recently forked, removing shift mode,
adding the ability to hide labels, and changing the way icons are
spaced.

TBR=twellington@chomrium.org

Bug: 738492
Change-Id: I0e41ceda79ff3e54ce51d9c77fbebb605dbc3b09
Reviewed-on: https://chromium-review.googlesource.com/641393
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499118}
Reviewed-on: https://chromium-review.googlesource.com/653477
Cr-Commit-Position: refs/branch-heads/3202@{#47}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech pushed a commit that referenced this pull request Oct 27, 2017
Activate native notification widget when clicked
470ad07 
Previously, Chrome OS native notification (NotificationViewMD) doesn't
get activated on click, while ARC notification (ArcNotificationView)
does.
This CL adds NotificationViewMD::EventForwarder, based on the
implementation of ArcNotificationContentView::EventForwarder.

This change is required for two reasons:
- Consistency with ARC notifications
- Future implementation of inline reply notification

TEST=manual
BUG=773618

Change-Id: I728cdfdd45896cf2a317b9d7e41d1a097e58aa4f
Reviewed-on: https://chromium-review.googlesource.com/718056
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#508987}(cherry picked from commit dcfd054)
Reviewed-on: https://chromium-review.googlesource.com/725006
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#47}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang pushed a commit that referenced this pull request Jan 29, 2018
Incrementing VERSION to 65.0.3325.14
22768d3 
TBR=dimu@chromium.org

Change-Id: I619038f6dad8b2b976839103a707a16382bef866
Reviewed-on: https://chromium-review.googlesource.com/882263
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#47}
Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech pushed a commit that referenced this pull request Mar 20, 2018
@darrnshn
[css-typed-om] Whitelist supported properties.
4180e8f 
This patch whitelists all our supported properties. Any property that
is not supported will return a base CSSStyleValue. This ensures that
we don't accidentally produce unexpected results for properties that
we haven't tested it.

We also add a few new properties to support, bringing the total number
of property tests to 50. We also remove support for 'z-index' because
it uses <integers> which we don't support yet.

transition-duration is failing tests because we currently convert
ms to seconds when we compute, which is incorrect.

Some paint/layout tests depend on properties that are not whitelisted,
so we've changed them:
- border-radius -> margin-left
- align-items -> empty-cell

Bug: 816402
Change-Id: I84d2fd8a15df92624122f0c1ecf4f7c42f928928
Reviewed-on: https://chromium-review.googlesource.com/942651
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540397}(cherry picked from commit 1ccb08d)
Reviewed-on: https://chromium-review.googlesource.com/952142
Cr-Commit-Position: refs/branch-heads/3359@{#47}
Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
@a1ph
DevTools: Fix timeline stop recording race.
a1d3708 
The recording could have already being stopped by the time auto stop kicks in.

BUG=832332
TBR=alph@chromium.org

(cherry picked from commit 4aa3813)

Change-Id: Ia25f8b7c3fc9c0ba62956ed5d8286fdcc786cdee
Reviewed-on: https://chromium-review.googlesource.com/1011399
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550655}
Reviewed-on: https://chromium-review.googlesource.com/1015294
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#47}
Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang pushed a commit that referenced this pull request Jun 19, 2018
Merge "Support safe browsing count in enterprise report API." to 68.
2fc760d 
The API now accepts safe browsing warning count and safe browsing warning
click through count.

Bug: 846453, 832907
Change-Id: Ied5eec64ab71f8fe3ef2cb65efd2f43bfceb3a68
Reviewed-on: https://chromium-review.googlesource.com/1072515
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562274}(cherry picked from commit f52452e)
Reviewed-on: https://chromium-review.googlesource.com/1079727
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#47}
Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech pushed a commit that referenced this pull request Aug 4, 2018
@plmonette-zz
Don't initialize the incompatible applications warning in Win8 and under
3b10a49 
The feature was never meant to be enabled on other versions than
Windows 10, but I accidentally removed the checks in
https://chromium-review.googlesource.com/c/chromium/src/+/1099976.

Bug: 717696
Change-Id: Ie52736de5dbf609fb702f6aff4a97f8ecac95267
Reviewed-on: https://chromium-review.googlesource.com/1144430
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#576957}(cherry picked from commit f315661)
Reviewed-on: https://chromium-review.googlesource.com/1148740
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#47}
Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang pushed a commit that referenced this pull request Sep 15, 2018
[Merge M70][Autofill] Replace 'remember' with 'save and fill' on toggles
cb768b7 
Bug: 879342
Change-Id: Ic2451cdbaa221f0dcd844c29ed8b732d68dc7d76
Reviewed-on: https://chromium-review.googlesource.com/1197360
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#587854}(cherry picked from commit 32c9ffb)
Reviewed-on: https://chromium-review.googlesource.com/1205718
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#47}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Oct 31, 2018
@tm-chromium
Dont crash on integer overflow
0dadf32 
Simply return an empty buffer and log an error.

Bug: 894941
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I02a70afb3f326c1a9a8b845f7bc8d1aa84cb5dad
Reviewed-on: https://chromium-review.googlesource.com/c/1281692
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599833}(cherry picked from commit fd1b409)
Reviewed-on: https://chromium-review.googlesource.com/c/1283935
Reviewed-by: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#47}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang pushed a commit that referenced this pull request Dec 18, 2018
child user: Enable PIN authentication for child user.
90b21c2 
PIN remains disabled for legacy supervised user.

Bug: 911335
Change-Id: I1603c6f00fa693702cab8639bd94056368866caa
Reviewed-on: https://chromium-review.googlesource.com/c/1359824
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613629}(cherry picked from commit 1974808)
Reviewed-on: https://chromium-review.googlesource.com/c/1362209
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#47}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Feb 10, 2019
@robbiemc
Fix ExternalFileURLLoader error handling
a4572ae 
When ExternalFileURLLoader gets an error when reading data from disk,
it handles the error, and then tries to continue copying data. This
makes it stop when it encounters an error.

Bug: 925565
Change-Id: I61938040c485ecd7e607363366433532281547e0
Reviewed-on: https://chromium-review.googlesource.com/c/1437706
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#626492}(cherry picked from commit 86d0536)
Reviewed-on: https://chromium-review.googlesource.com/c/1443964
Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/branch-heads/3683@{#47}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang pushed a commit that referenced this pull request Mar 24, 2019
@npm1
[ElementTiming] Expose cross origin elements that do not pass TAO
e1d8189 
After this CL, elements that do not pass TAO checks are still exposed
via ElementTiming, but with a startTime of 0. This makes the API in line
with the newly approved security/privacy reviews.

Bug: 879270, 939964
Change-Id: I8cd72475595d9358edcf2fa414ce2cabf07c2495
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505849
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#639265}(cherry picked from commit 4b82ec798a170d97accafbe15b7698ed6c6a9ffa)
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518594
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/branch-heads/3729@{#47}
Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ghostoy @dobriai @rogerwang