Cert error on webview #12

janRucka · 2016-03-24T18:19:35Z

Allow custom handling of invalid certificates on webview.

Currently only way to handle invalid certificate is via chrome-like error page. There is no way to how to handle it automatically. But we need to be able to do it automatically or via custom UI and this pull request allows it. And we think there are more people which would appreciate this functionality.

Solution:

We added 'useautomaticcerthandling' attribute on webview. If used following needs to be used to handle certificate errors:
-‘certificateerror’ event on webview to get informed when invalid certificate occur.
-‘allowCertificate’ function on webview so it is possible allow certificate programmatically.

If 'useautomaticcerthandling' attribute is used default (chrome like) error page is not showed so it is necessary to handle it programmatically. If 'useautomaticcerthandling' attribute is not used everything works without changes (user will see error page as it is now).

Examples:

Working with our changes in code. In example there are two webview first is handled automatically (certificate is allowed immediately as you can see in javascript code), second is without parameter and user needs to handle it.

certificate.zip

BUG=663953 TEST=paint/invalidation/svg/image-animation-with-zoom.html Review-Url: https://codereview.chromium.org/2509113004 Cr-Commit-Position: refs/heads/master@{#433228} (cherry picked from commit 8934714) Review URL: https://codereview.chromium.org/2520703002 . Cr-Commit-Position: refs/branch-heads/2924@{#12} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}

BUG=682574 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2645963003 Cr-Commit-Position: refs/heads/master@{#445182} (cherry picked from commit b281bde) Review-Url: https://codereview.chromium.org/2652513002 . Cr-Commit-Position: refs/branch-heads/2987@{#12} Cr-Branched-From: ad51088-refs/heads/master@{#444943}

AddWatcher() and RemoveWatcher() are added. Also, ArcFileSystemOperationRunner implements FileSystemHost to receive watcher callbacks from the Android container. BUG=chromium:684233 TEST=trybot Review-Url: https://codereview.chromium.org/2715493002 Cr-Commit-Position: refs/heads/master@{#454589} (cherry picked from commit 1cf2cd5) Review-Url: https://codereview.chromium.org/2736603002 . Cr-Commit-Position: refs/branch-heads/3029@{#12} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}

BUG=711580 Review-Url: https://codereview.chromium.org/2814273006 Cr-Commit-Position: refs/heads/master@{#464685} (cherry picked from commit 736905b) Review-Url: https://codereview.chromium.org/2822923002 . Cr-Commit-Position: refs/branch-heads/3071@{#12} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

-Webview now has: --Attribute 'useautomaticcerthandling' added on webview. If allowed following needs to be used (not possible to handle it for users) --onCertificateError event (when page with invalid certificate is opened) --allowCertificate function (to allow page with invalid certificate) -Don't load subframes with invalid certificate. --'subframecertificateerror' event on webview added (when page containing subframe with invalid certificate is opened). # Conflicts: # extensions/browser/guest_view/web_view/web_view_constants.cc # extensions/browser/guest_view/web_view/web_view_constants.h # extensions/renderer/resources/guest_view/web_view/web_view_attributes.js # extensions/renderer/resources/guest_view/web_view/web_view_constants.js # extensions/renderer/resources/guest_view/web_view/web_view_events.js

janRucka · 2017-05-23T11:36:19Z

Updated to nw22.

For details see documentation:
nwjs/nw.js#5925

Related:
nwjs/nw.js#5794

Our project:
https://groups.google.com/forum/#!topic/nwjs-general/TmZUq-JHIuQ

This reverts commit 1b60006. Reason for revert: Causes a startup crash with chrome --mash, possibly because mash does not have a DeviceDataManager. You might want to check with sadrul@ or rjkroege@ about whether there's a good way to do this under mash. Failing build (chromeos-side waterfall): https://luci-milo.appspot.com/buildbot/chromeos.chrome/tricky-tot-chrome-pfq-informational/5205 Stack (from running manually with chrome --mash on Linux): [60089:60089:0717/114019.863351:FATAL:device_data_manager.cc(84)] Check failed: instance_. DeviceDataManager was not created. #0 0x7f06a03468bc base::debug::StackTrace::StackTrace() #1 0x7f06a036a121 logging::LogMessage::~LogMessage() #2 0x7f069aeb08ff ui::DeviceDataManager::GetInstance() #3 0x55f183402a41 chromeos::LoginDisplayHostImpl::LoginDisplayHostImpl() #4 0x55f1834066ad chromeos::ShowLoginWizard() #5 0x55f1833e4bf7 chromeos::ChromeSessionManager::Initialize() #6 0x55f1832f9cb4 chromeos::ChromeBrowserMainPartsChromeos::PostProfileInit() #7 0x55f1837e7aa2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #8 0x55f1837e709d ChromeBrowserMainParts::PreMainMessageLoopRun() #9 0x55f1832f8f4a chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #10 0x7f069d9e5081 content::BrowserMainLoop::PreMainMessageLoopRun() #11 0x7f069dde6407 content::StartupTaskRunner::RunAllTasksNow() #12 0x7f069d9e353b content::BrowserMainLoop::CreateStartupTasks() #13 0x7f069d9e7a72 content::BrowserMainRunnerImpl::Initialize() #14 0x7f069d9e0b57 content::BrowserMain() #15 0x7f069e1e8462 content::ContentMainRunnerImpl::Run() #16 0x7f06a0890d39 service_manager::Main() #17 0x7f069e1e7384 content::ContentMain() #18 0x55f182e8132f ChromeMain #19 0x7f069454af45 __libc_start_main #20 0x55f182e81194 <unknown> Original change's description: > Listen to changes to touch input devices > > In https://codereview.chromium.org/2964823002 the OobeDisplayChooser > started using the DeviceDataManager to look for touchscreen devices when > searching for a good primary display to use during OOBE. > > On device cold boot the DeviceDataManager has not yet found any > touchscreen devices at the time OobeUi::ShowOobeUI() is called (likely > due to lower level systems not being fully initialized). > > This CL make LoginDisplayHostImpl an observer of changes to connected > touchscreen devices, re-triggering the OobeDisplayChooser when the > DeviceDataManager is notified of the connected touchscreens. This > overcomes the timing issues on cold boot. > > Bug: 738885 > Change-Id: Iae488ddc9428b7c5e74d36cf18e35ba3d1235bbd > Reviewed-on: https://chromium-review.googlesource.com/569958 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: Felix Ekblom <felixe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487007} TBR=alemate@chromium.org,jdufault@chromium.org,felixe@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. (cherry picked from commit 0cd134a) Bug: 738885 Change-Id: If31322734e679bbb1f4eef0a9aa802d34263cba4 Reviewed-on: https://chromium-review.googlesource.com/574731 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#487191} Signed-off-by: Bernie Thompson <bhthompson@google.com> Reviewed-on: https://chromium-review.googlesource.com/575149 Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#623} Cr-Branched-From: b6460e2-refs/heads/master@{#474897}

…when not in use This CL is part of the Mojo Video Capture work. Design doc for dev work [1]. Before this CL, the ServiceVideoCaptureProvider had to be uninitialized manually by its client, in our case VideoCaptureManager, in order to close the connection to the video capture service and, in turn, allow the service to shut down. VideoCaptureManager only called Uninitialize() at the end of a video capture session. But it would not call it after enumeration-only use of the service. This would lead to the service potentially staying alive indefinitely after enumeration-only usage that is not followed-up by a capture session. Usage logs indicate that this actually happens quite frequently. After this CL, ServiceVideoCaptureProvider uninitializes the service connection automatically as soon as there is no active usage. Bug: 584797 [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing TBR=chfremer@chromium.org (cherry picked from commit b7a3b14) Change-Id: Ia33507f4fe0a36b804b2636c41af6d807fab8c0d Reviewed-on: https://chromium-review.googlesource.com/578558 Reviewed-by: Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#488726} Reviewed-on: https://chromium-review.googlesource.com/583812 Reviewed-by: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#12} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}

… id:330001 of https://codereview.chromium.org/2978443002/ ) Reason for revert: Wasn't thinking when I landed this just before branch. Original issue's description: > Make ProfileIOData use URLRequestContextBuilder > > BUG=734199 > > Review-Url: https://codereview.chromium.org/2978443002 > Cr-Commit-Position: refs/heads/master@{#487590} > Committed: https://chromium.googlesource.com/chromium/src/+/189ddf60b2f4034a2ab6efb16e22ea389b2b779f TBR=mmenke@chromium.org, rdsmith@chromium.org BUG=734199,746576#c3 (cherry picked from commit 8636cbd) Review-Url: https://codereview.chromium.org/2986623002 Cr-Original-Commit-Position: refs/heads/master@{#488562} Change-Id: Iff1b60065f76c6fad9aea8e82c5fa7a3ff584ebc Reviewed-on: https://chromium-review.googlesource.com/585894 Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#47} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}

TBR=hejq@google.com (cherry picked from commit 440a5fe) Bug: 761155 Change-Id: I2d6f1e7aa8875e102b823818a6d275a3302c454b Reviewed-on: https://chromium-review.googlesource.com/646831 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Original-Commit-Position: refs/heads/master@{#499301} Reviewed-on: https://chromium-review.googlesource.com/648667 Reviewed-by: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#12} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

This CL fixes a race that made it possible for an isolated origin to end up incorrectly sharing a process with a non-isolated origin. The race involved one of the origins reaching NavigationRequest::OnResponseStarted, which in PlzNavigate would make the final determination on which process the response should commit in, but before the DidCommit message arrived, another navigation ended up incorrectly reusing the same process. This is because the process was marked as "used" in DidCommit. There are actually two separate races here, depending on which origin reaches OnResponseStarted first, both fixed in this CL: 1. The non-isolated origin reaches OnResponseStarted in one tab, and then before it receives its DidCommit, we navigate another tab to an isolated origin with process reuse in effect. This should *not* reuse the first tab's process. To do this, we mark the process as "used" in OnResponseStarted. Then, when the isolated origin picks its process, IsSuitableHost() will return false for that process because IsUnused() will be false. 2. The isolated origin reaches OnResponseStarted in one tab, and then before it receives its DidCommit, we navigate another tab to a non-isolated origin with process reuse in effect. This is problematic because we were allowing lazily-initialized SiteInstances for isolated origins, which would only execute LockToOrigin at DidCommit time. Marking the process as used in OnResponseStarted isn't sufficient here: because the first tab process's origin lock isn't set when the second tab navigates, IsSuitableHost() doesn't see a problem because the non-isolated origin doesn't require a dedicated process, even though the process is already marked as used. This race shows that delaying LockToOrigin until DidCommit is not safe, so this CL also ensures that SiteInstances for sites requiring a dedicated process initialize their site URLs (and hence perform LockToOrigin()) earlier, in OnResponseStarted, once the process is "committed" to the site. TBR=alexmos@chromium.org (cherry picked from commit 54bf130) Bug: 738634 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Iaf04204b6c21f411924be5eaf5372909230e6545 Reviewed-on: https://chromium-review.googlesource.com/636787 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#508590} Reviewed-on: https://chromium-review.googlesource.com/721763 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#12} Cr-Branched-From: adb61db-refs/heads/master@{#508578}

This reverts commit e7b1ef1. Reason for revert: <INSERT REASONING HERE> Original change's description: > macOS V2 Sandbox: Improve GPU Performance and Resolve Crashes. > > This resolves performance and stability issues with the GPU > process when run under the V2 sandbox. Its add an API call to > prevent the sandbox from waiting on launchservicesd, and allows > access to necessary mach services. > > Bug: 797730 > Change-Id: If5690bf2b76bb7ec66f4644b3795b1a6ce4baecd > Reviewed-on: https://chromium-review.googlesource.com/865945 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530277} TBR=creis@chromium.org,kerrnel@chromium.org,rsesek@chromium.org,piman@chromium.org Change-Id: I6a71fbdaa822aa1ed1d073458092c7b04f65ce0d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 797730 Reviewed-on: https://chromium-review.googlesource.com/876702 Reviewed-by: Greg Kerr <kerrnel@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#530592}(cherry picked from commit 16cd78c) Reviewed-on: https://chromium-review.googlesource.com/877664 Cr-Commit-Position: refs/branch-heads/3325@{#12} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}

…se cursor. The event rewriter needs to allow mouse movement events to pass even when those events are used by Select-to-Speak. It should only cancel mouse click events used by Select-to-Speak. Another solution would be to re-write all used "drag" events to be simply "move" events, which may reduce the likelyhood that these events will be used by any other part of Chrome / Chrome OS besides Select-to-Speak and drawing the mouse. This bug also impacted some devices (like snappy) even without large mouse cursor on. Note: The additional "drag" and "move" events were manually tested and do not appear to cause any behavior problems on tabs, the launcher, system windows, etc. TBR=dmazzoni@chromium.org Bug: 818329 Change-Id: I466a15a0f7a5ba0abe4f082a9cfb9b59760d690c Reviewed-on: https://chromium-review.googlesource.com/947210 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540714}(cherry picked from commit 8f6ebbb) Reviewed-on: https://chromium-review.googlesource.com/949079 Reviewed-by: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#12} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}

TBR=dimu@chromium.org Change-Id: Id540e4704ff92161b9e72a17f536343168d13c0c Reviewed-on: https://chromium-review.googlesource.com/1012541 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#12} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}

…ect outdated server This enables Initial Enrollment by default for official builds. Also, this adds functionality to detect a server which does not support Initial Enrollment by comparing against a maximal expected modulus value. TBR=pmarko@chromium.org (cherry picked from commit 83a6b57) Bug: 839353 Test: unit_tests --gtest_filter=AutoEnrollmentClient* Change-Id: I1b64ab2875c7317dc92c74276173e27b1c58bbe2 Reviewed-on: https://chromium-review.googlesource.com/1073309 Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#562143} Reviewed-on: https://chromium-review.googlesource.com/1075272 Reviewed-by: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#12} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}

…iner https://chromium-review.googlesource.com/c/chromium/src/+/1091497 removed an item from the app menu that never appeared on Mac. Unfortunately, even though the item was never *displayed*, it appears to have factored into NSMenu's calculation for what its max size should be. When the item was removed, the max size is no longer able to account for multiple rows in the browser action overflow container, so all rows but the last are clipped. This change removes and readds the extension overflow container when it's finished sizing itself to prompt the menu to reevaluate its height. We can't do this before we add the item to the menu because the menu's width factors into the overflow container's size calculation. It seems like there should be a less awkward way to do this, but I can't find it. Bug: 862005 Change-Id: Ib17ed810855041226786b16ca94f0a60d88dc892 Reviewed-on: https://chromium-review.googlesource.com/1145133 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#576905}(cherry picked from commit 8634192) Reviewed-on: https://chromium-review.googlesource.com/1146780 Reviewed-by: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#12} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}

This CL adds a histogram to track which of three possible interactions were used to change the current page in the tab grid. Bug: 879487 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I35d6cb289b4c9fb8418e8d40f356bf914ae5d302 Reviewed-on: https://chromium-review.googlesource.com/1193948 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#587974}(cherry picked from commit f35d6bb) Reviewed-on: https://chromium-review.googlesource.com/1201858 Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#12} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}

TBR=kariah@chromium.org Change-Id: If95b0fb3204ffe81e3755a4f981b6e1dbd0bbc39 Reviewed-on: https://chromium-review.googlesource.com/c/1278911 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#12} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}

The problem here is that between CachedImageFetcherImpl's FetchImage invocation and completion, destroy was called on InMemoryCachedImageFetcher. This causes an attempt to store the image in a null bitmap cache. This just checks if the bitmap cache is null before attempting to store an image. TBR=twellington@chromium.org,fgorski@chromium.org Bug: 910080 Change-Id: I28b7aaee8588d883cfaf98328e2e58478d452375 Reviewed-on: https://chromium-review.googlesource.com/c/1355770 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612857}(cherry picked from commit 74b8c22) Reviewed-on: https://chromium-review.googlesource.com/c/1359054 Cr-Commit-Position: refs/branch-heads/3626@{#12} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}

* Apply Blur/Sield animation after transform animation. * Skip blur animation if the wallapper already have the target blur sigma. I moved ShouldAnimateWallpaper to OverviewGrid. Bug: 924396, 924221 Test: covered by unit tests. Change-Id: Ib2a07484efada16b2487be9b943549b237004505 Reviewed-on: https://chromium-review.googlesource.com/c/1432881 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Sammie Quon <sammiequon@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#626031}(cherry picked from commit 1a8df9c) Reviewed-on: https://chromium-review.googlesource.com/c/1438056 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#12} Cr-Branched-From: e510299-refs/heads/master@{#625896}

This CL adds new IPH to promote Chrome's DataSaver when the user hits a large milestone of saved data, like 1 GB. Also changes uses TextBubble's new String-based constructor in ToolbarButtonInProductHelpController and adds an optional on dismiss callback which is used for this IPH. This CL is 3 of 4 to move the DataSaver "Chrome saved you XX data" from a snackbar to an IPH. Bug: 939833 Change-Id: Ic1bb54af54b06d80596f504893ee64043537f0a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492359 Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#639222}(cherry picked from commit 94273f2e68c3190094377c7c01baef7caadab4c1) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513047 Reviewed-by: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#12} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}

rogerwang force-pushed the nw13 branch 9 times, most recently from b5bfa94 to 802e375 Compare March 29, 2016 15:19

rogerwang force-pushed the nw13 branch 6 times, most recently from 53ac9e0 to dc5c466 Compare April 7, 2016 22:01

rogerwang force-pushed the nw13 branch 4 times, most recently from 114f968 to f581ec8 Compare April 13, 2016 11:56

janRucka force-pushed the certErrorOnWebview branch from 2c81cc4 to 9c2983e Compare May 23, 2017 11:30

janRucka changed the base branch from nw13 to nw22 May 23, 2017 11:31

janRucka mentioned this pull request May 23, 2017

Cert error on webview documentation nwjs/nw.js#5925

Closed

janRucka mentioned this pull request May 23, 2017

Allow providing custom handler for certificate validation nwjs/nw.js#5794

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cert error on webview #12

Cert error on webview #12

janRucka commented Mar 24, 2016

janRucka commented May 23, 2017

Cert error on webview #12

Are you sure you want to change the base?

Cert error on webview #12

Conversation

janRucka commented Mar 24, 2016

Allow custom handling of invalid certificates on webview.

Solution:

Examples:

janRucka commented May 23, 2017