Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookies API on webview. #69

Closed
wants to merge 1 commit into from
Closed

Cookies API on webview. #69

wants to merge 1 commit into from

Conversation

janRucka
Copy link
Contributor

@janRucka janRucka commented Mar 3, 2017 •
edited

Basically the same as chrome API but this one is working for webview:
https://developer.chrome.com/extensions/cookies

Our project:
https://groups.google.com/forum/#!topic/nwjs-general/TmZUq-JHIuQ

@janRucka
Cookies API on webview.
bb0f93f 
Basically duplicate of chrome.cookies API via following API function on Webview:
'cookiesGet'
'cookiesGetAll'
'cookiesSet'
'cookiesRemove'

CookieStore or storeId currently not supported.
@rogerwang
Copy link
Member

Could you please add documentation and submit to nw21 the upcoming stable branch?
The documentation should be in https://github.com/nwjs/nw.js/tree/nw21/docs

@rogerwang
Copy link
Member

https://github.com/nwjs/nw.js/blob/nw21/docs/References/webview%20Tag.md

@janRucka
Copy link
Contributor Author

janRucka commented Mar 7, 2017

I create new pull requests (so feel free to close this one):
nwjs/chromium.src:
#71

and for documentation:
nwjs/nw.js:
nwjs/nw.js#5750

@rogerwang rogerwang closed this Mar 8, 2017
rogerwang pushed a commit that referenced this pull request Mar 11, 2017
@twifkak
Add Precache.Fetch.ResponseBytes.Daily.
50d2174 
This measures how much of the daily_quota_total is used, allowing us to
predict what the effects will be if we tweak that parameter.

BUG=698933

Review-Url: https://codereview.chromium.org/2735923002
Cr-Commit-Position: refs/heads/master@{#455323}
(cherry picked from commit fd9e5cd)

Review-Url: https://codereview.chromium.org/2736323002 .
Cr-Commit-Position: refs/branch-heads/3029@{#69}
Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech pushed a commit that referenced this pull request Apr 26, 2017
@yellowdoge
ImageCapture: don't list |torch| in Capabilities if not supported
89bfdc0 
Currently MediaStreamTrack.getCapabilities() returns
 torch : false

when |torch| is not supported; this CL aligns with the
other dictionary members behaviour, which is to not
show up in the Capabilities dictionary when not supported.

BUG=712719

Review-Url: https://codereview.chromium.org/2827693003
Cr-Commit-Position: refs/heads/master@{#465373}
(cherry picked from commit 31b31da)

Review-Url: https://codereview.chromium.org/2830943002 .
Cr-Commit-Position: refs/branch-heads/3071@{#69}
Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech pushed a commit that referenced this pull request Aug 5, 2017
Incrementing VERSION to 61.0.3163.15
c1ea416 
TBR=dimu@chromium.org

Change-Id: I0c8892664c8be2aee057af08e8cee029c06d2c4e
Reviewed-on: https://chromium-review.googlesource.com/588131
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#69}
Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech pushed a commit that referenced this pull request Sep 14, 2017
Restore broken tab crashed icon animation.
53f831c 
TBR=estade@chromium.org

(cherry picked from commit 30985d1)

Bug: 761910
Change-Id: I1182e7651e75115d906990357d772439f9a4057d
Reviewed-on: https://chromium-review.googlesource.com/653497
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500009}
Reviewed-on: https://chromium-review.googlesource.com/655816
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#69}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech pushed a commit that referenced this pull request Oct 27, 2017
@iotitan
[Home] Fix feature util inconsistency
fea99ff 
This change fixes inconsistency with the feature utils check for
Chrome Home. Instead of immediately changing the cached static value
when the promo is used, it is delayed until the browser is shut down.
This allows any users that depend on that value to run properly.

BUG=775079
TBR=mdjones@chromium.org

(cherry picked from commit 83cdd1b)

Change-Id: Id75d1c51ef319b00ae393a96e7e886e7d56e3253
Reviewed-on: https://chromium-review.googlesource.com/723842
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509797}
Reviewed-on: https://chromium-review.googlesource.com/728326
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#69}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang pushed a commit that referenced this pull request Jan 29, 2018
@freshp86
Settings UI CrOS: Restore search functionality.
9ae7a18 
The code was erroneously dismissing search results in some cases.

TBR=dpapad@chromium.org

(cherry picked from commit cb83f77)

Bug: 757727
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6afbec34b7a7e187fcf7f168b31be6261a0a249b
Reviewed-on: https://chromium-review.googlesource.com/879492
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531111}
Reviewed-on: https://chromium-review.googlesource.com/884109
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#69}
Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech pushed a commit that referenced this pull request Mar 20, 2018
@kainino0x
Revert "Experimentally removing MSAA workaround for perf bot"
0f69985 
This reverts commit 23b2d93.

Reason for revert: Experiment complete. I don't think this workaround should be kept.

Original change's description:
> Experimentally removing MSAA workaround for perf bot
>
> The perf bot perf.chromium-rel-mac12 has alerted on a ~50% slowdown in
> http___webglsamples.org_dynamic-cubemap_dynamic-cubemap.html .
> In the regression range was my seemingly closely
> related CL: https://crrev.com/c/923103
> But that commit should improve performance, not regress it.
>
> So this CL adds an exception to the workaround in 923103, so that
> that workaround does not apply on perf.chromium-rel-mac12.
> This should help determine whether my CL really caused a regression.
>
> I'm expecting this CL to cause a regression in
> http___kenrussell.github.io_webgl-animometer_Animometer_tests_3d_webgl.html
> (undoing the recent improvement caused by 923103).
>
> Bug: 815154
> Change-Id: I335133a127bb7cfcb92ba29065641dfd55b63166
> Reviewed-on: https://chromium-review.googlesource.com/938844
> Commit-Queue: Kai Ninomiya <kainino@chromium.org>
> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
> Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540237}

TBR=kainino@chromium.org, zmo@chromium.org

Change-Id: Iddc41a8cda141d2722a1fd9c1980604dfa61a0d3
No-Try: true
Bug: 815154
Reviewed-on: https://chromium-review.googlesource.com/946608
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540566}(cherry picked from commit 301e786)
Reviewed-on: https://chromium-review.googlesource.com/947253
Cr-Commit-Position: refs/branch-heads/3359@{#69}
Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
@danblakemore
Return nothing for the signed in user until the correct user can reli…
36b2fe8 
…ably be returned.

Bug: 810904
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibd9bae957927fa3fa78569792c58015e1b6039f0
Reviewed-on: https://chromium-review.googlesource.com/1013682
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Daniel Blakemore <danblakemore@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#551189}(cherry picked from commit 855ba32)
Reviewed-on: https://chromium-review.googlesource.com/1015203
Cr-Commit-Position: refs/branch-heads/3396@{#69}
Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang pushed a commit that referenced this pull request Jun 19, 2018
@mrefaat88
[Merge M68]Check if weak_system_store object is valid before using it.
64bef94 
This may have caused the crash in crbug/847026

Bug: 847026
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia3b4a4a756aec2898f8933173a61bdb097f935b5
Reviewed-on: https://chromium-review.googlesource.com/1076672
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562573}(cherry picked from commit 2e6de02)
Reviewed-on: https://chromium-review.googlesource.com/1081068
Cr-Commit-Position: refs/branch-heads/3440@{#69}
Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech pushed a commit that referenced this pull request Aug 4, 2018
@junov
Add missing null check to OffscreenCanvas::PushFrame
c163f8a 
BUG=866273
TBR=junov@chromium.org

(cherry picked from commit 4eb4529)

Change-Id: Ie53ffb789b005089813f11f26f4425a8f8884b0f
Reviewed-on: https://chromium-review.googlesource.com/1147461
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577326}
Reviewed-on: https://chromium-review.googlesource.com/1150205
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#69}
Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang pushed a commit that referenced this pull request Sep 15, 2018
[Merge to M70] cros: Update offline Highlights app resources path
5bce327 
After the ebuild update, Chrome can assume there's only one version
of the Highlights app existing at a time, and it's the correct version
so board checking is not necessary.


TBR=wzang@chromium.org

(cherry picked from commit 2f46b69)

Bug: 819404
Change-Id: I29b837131376a1c47ac3458bb98643c0bfa14e7d
Reviewed-on: https://chromium-review.googlesource.com/1197364
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#587823}
Reviewed-on: https://chromium-review.googlesource.com/1208142
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#69}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Oct 31, 2018
@rakina
Add deadline to Find-in-page idle tasks
370d5b4 
In some cases such as multiple frame webpages, idle task might never
execute or take a noticably long time to execute. This might lead to
incorrect number of find-in-page result and not highlighting matches
because the scoping is never trigerred. This CL adds a deadline to
scoping idle tasks to ensure all scoping happens in a timely manner.

Bug: 890622,893465
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I8ec998d4c2f42377361c1f7b95c1497a80368ef6
Reviewed-on: https://chromium-review.googlesource.com/c/1270196
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599562}(cherry picked from commit 0df2607)
Reviewed-on: https://chromium-review.googlesource.com/c/1285149
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#69}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang pushed a commit that referenced this pull request Dec 18, 2018
[M72 Merge][Managed Session] Don't override LidCloseAction policy cli…
afe025c 
…ent side (do it server side)

Currently, LidCloseAction overrides any values sent down from the server to ACTION_STOP_SESSION.

We want to support enterprise use cases where the policy value would be something else, so stop
overriding the value on the client-side as it will be handled server-side.

Sleep on Lid Close In Managed Guest Sessions PRD:

https://docs.google.com/document/d/18E1FIHTuGApW0-Uj5fkkQsH_K0nYHRyRSlaKfLZs4B8/edit?ts=5bd0d169#


(cherry picked from commit 124402e)

Bug: 902361
Change-Id: I2ff3b5dc99fce8e4248341896fec3c8f21eb4fec
Reviewed-on: https://chromium-review.googlesource.com/c/1320171
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613489}
Reviewed-on: https://chromium-review.googlesource.com/c/1362932
Reviewed-by: Ivan Šandrk <isandrk@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#69}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Feb 10, 2019
cros: tablet mode: Observe Homecher Animations beginning and ending
2d218f9 
Observe homecher animations beginning and ending, this will allow us
to better coordinate shelf background animations.

Bug: 920420
Change-Id: I3efd0bcecb3acd5d10968ad1d78d89d1689098f6
Reviewed-on: https://chromium-review.googlesource.com/c/1418525
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#627035}(cherry picked from commit 3366b20)
Reviewed-on: https://chromium-review.googlesource.com/c/1446562
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/branch-heads/3683@{#69}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang pushed a commit that referenced this pull request Mar 24, 2019
@anforowicz
[m74] Adding 2 extensions to the allowlist.
3d0a2d1 
TBR=lukasza@chromium.org

(cherry picked from commit fe8dd924c42b8d4089c2da26227220b3f6e7df0e)

Bug: 937081
Change-Id: Ie8f649446db7f687baa8b116bfad2c300192cddf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512258
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#639130}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518852
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/branch-heads/3729@{#69}
Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@janRucka @rogerwang