Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS on dl.nwjs.io #3062

Closed
timmclean opened this issue Feb 7, 2015 · 10 comments
Closed

HTTPS on dl.nwjs.io #3062

timmclean opened this issue Feb 7, 2015 · 10 comments
Assignees
Milestone

Comments

@timmclean
Copy link

Currently, the only way to download NW.js is over an insecure HTTP connection. Most projects provide either an HTTPS download link, or PGP signatures that let you verify that what you downloaded hasn't been tampered with. It would be great if dl.nwjs.io supported HTTPS or provided signatures.

Some general background on the risks with using insecure HTTP: http://mashable.com/2011/05/31/https-web-security/

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@timmclean
Copy link
Author

related: nwjs/npm-installer#2

@mjethani
Copy link

Hi, any progress on this?

You could just sign the builds with PGP and publish your keys. Alternatively, you could simply post the SHA-256 hashes right here on GitHub. There are many ways to do it.

Right now the only way to use NW.js securely is to build it from source.

@rogerwang
Copy link
Member

Will look to fix this soon.

@rogerwang rogerwang added this to the 0.14.x milestone Apr 26, 2016
@evshiron
Copy link
Contributor

+1 for this. Currently I am taking effort to provide a public mirroring for nw.js, but I find that every previous upstream source uses HTTPS, some also provides signatures to verify with, which will prevent most of the tampering, but nw.js doesn't. So the plan is put on hold.

@rogerwang
Copy link
Member

This is now supported. https://dl.nwjs.io

@evshiron
Copy link
Contributor

evshiron commented Aug 3, 2016

@rogerwang Thanks! Glad to tell you that nw.js has a mirror at https://npm.taobao.org/mirrors/nwjs/ now, which is synchronized from Amazon S3 via HTTPS :)

@mjethani
Copy link

mjethani commented Aug 3, 2016

Thank you!

@rogerwang
Copy link
Member

@evshiron thanks. but please use dl.nwjs.io. Do NOT use S3.

@evshiron
Copy link
Contributor

evshiron commented Aug 4, 2016

@rogerwang The mix of Apache DirectoryIndex and Amazon S3 Bucket is somewhat confusing and hard to synchronize with.
Related: cnpm/mirrors#107

@rogerwang
Copy link
Member

OK. It LGTM for now after checking the mirror script. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants