Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.15-*] webview.clearData make crash #5087

Closed
lin-chao opened this issue Jul 7, 2016 · 7 comments
Closed

[0.15-*] webview.clearData make crash #5087

lin-chao opened this issue Jul 7, 2016 · 7 comments
Assignees
@rogerwang

Comments

@lin-chao
Copy link

lin-chao commented Jul 7, 2016

execute webview.clearData make nw crash

version: 0.15-*
os: both mac and win

test code:

{
  "main": "index.html",
  "name": "demo",
  "window": {
    "width": 900,
    "height": 900
  }
}

<!DOCTYPE html>
<html>
<head>
  <meta charset="utf-8">
</head>
<body style="width:800px; height:800px">
  <div style="width:800px; height:800px">
    <webview src="http://xw.qq.com" id="webview" style="display:block;width:700px; height:700px"></webview>
  </div>
  <button id="clear">clear data</button>
  <script type="text/javascript">
  window.onload = () => {
    var webview = document.getElementById('webview')
    var clear = document.getElementById('clear')

    clear.addEventListener('click', () => {
      var data = {
        appcache: true,
        cache: true,
        fileSystems: true,
        indexedDB: true,
        localStorage: true,
        webSQL: true
      }
      webview.clearData({
        since: 0
      }, data, () => {
        console.info('WebviewBody.js _clearWebviewData success!')
      })
    })
  }
  </script>
</body>

</html>
@rogerwang rogerwang self-assigned this Jul 8, 2016
@rogerwang
Copy link
Member

@ghostoy , OP's report is good enough with a case. I can reproduce it with the case. No further information is needed.

@rogerwang
Copy link
Member

rogerwang commented Jul 8, 2016 •
edited
Loading

This is fixed in git and will be available in the next nightly build.

Note that the next stable release will be 0.16.0 soon. There will be no more 0.15.x releases.

@rogerwang
Copy link
Member

http://dl.nwjs.io/live-build/07-11-2016/nw16-e410c99-c556dbe-d88e3a2-77f39b5/v0.16.0/

@lin-chao
Copy link
Author

hi @rogerwang

i tested on my windows(win7 Windows 64-bit)

click "clear button" twice, nw crash again.

download minidump file

@rogerwang rogerwang reopened this Jul 11, 2016
@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

@rogerwang
Copy link
Member

http://dl.nwjs.io/live-build/07-12-2016/nw16-e410c99-10b4d75-cd7731c-3151ede/v0.16.0/

btw, clearData() may not work for webview, see http://crbug.com/615429

@lin-chao
Copy link
Author

lin-chao commented Jul 12, 2016 •
edited
Loading

i tested on mac and win, both work fine now. thanks ~

And clearData() always worked in my project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rogerwang rogerwang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rogerwang @lin-chao