Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evalNWBin() not working in 0.16.1? #5236

Closed
ghost opened this issue Aug 25, 2016 · 3 comments
Closed

evalNWBin() not working in 0.16.1? #5236

ghost opened this issue Aug 25, 2016 · 3 comments
Assignees

Comments

@ghost
Copy link

ghost commented Aug 25, 2016

I wanted to update the NW.js version in my app to make use of the new Chrome App functions, so I replaced the NW.js SDK and converted my .js files to bin using the new nwjc

When I ran the app though, no error or problems but seemed like Javascript was... disabled or something. So with further tests, I saw that evalNWBin() was simply not working.

I made a small sample to make sure that was the case and it seems the line,
nw.Window.get().evalNWBin(null, "bins/test.bin");
is never executed

Here is the file, just drop it in your 0.16.1 SDK folder and run nw.exe

edit: Googling the issue seems I've found another user with the same issue too here

@ghostoy ghostoy self-assigned this Aug 26, 2016
@ghostoy
Copy link
Member

ghostoy commented Aug 26, 2016

@alexandervrs Did you see this issue when DevTools is open? It's a known issue #3388.

The reason is that v8 won't load the serialized code blob when debugger is attached: https://github.com/nwjs/v8/blob/nw12/src/compiler.cc#L1291

@ghost
Copy link
Author

ghost commented Sep 3, 2016

I am using the SDK version of NW.js. I am not sure if the Dev Tools were open, but I believe it didn't work even if they were closed. I've since, just loaded the scripts with regular <script src> and then it works.

@ghostoy
Copy link
Member

ghostoy commented Sep 14, 2016

@alexandervrs I can't reproduce this issue with both 0.16.1 or 0.17.0 on both Mac and Windows. I'm closing this bug until we can figure out a way to reproduce.

@ghostoy ghostoy closed this as completed Sep 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant