New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(get): simplify symlink logic #1035

Merged

ayushmanchhabra merged 1 commit into main from chore/unzip-symlink-simplify

Feb 15, 2024

Collaborator

ayushmanchhabra commented Feb 15, 2024

Current implementation: write entry as file, check if entry is symlink, remove file and create symlink
Improved implementation: check if entry is symlink, stream entry to buffer, extract link target and create symlink. Otherwise, stream entry to file.

Refs: #1030


          chore(get): simplify symlink logic

5eba83d

ayushmanchhabra merged commit 4f64307 into main

3 checks passed

ayushmanchhabra deleted the chore/unzip-symlink-simplify branch

February 15, 2024 19:36

github-actions bot mentioned this pull request

chore(main): release 4.6.1 #1034

Merged

ayushmanchhabra pushed a commit that referenced this pull request


          chore(main): release 4.6.1 (#1034)

b94decf

🤖 I have created a release *beep* *boop*
---


##
[4.6.1](v4.6.0...v4.6.1)
(2024-02-15)


### Chores

* **ci:** add chores section to changelog
([#1028](#1028))
([d630720](d630720))
* **ci:** fixup release please action
([#1032](#1032))
([f9ae7cd](f9ae7cd))
* **ci:** remove `schema` prop
([33238b1](33238b1))
* **deps:** bump the gha group in /.github/workflows with 1 update
([70030df](70030df))
* **docs:** update PR template to simplify commit descriptions
([#1029](#1029))
([6da9b89](6da9b89))
* **docs:** update readme and changelog
([63fd50b](63fd50b))
* fix remaining lint errors
([334ae74](334ae74))
* **get:** refactor implementation
([#1025](#1025))
([72f65e1](72f65e1))
* **get:** refactor unzip symlink implementation
([#1030](#1030))
([69661c3](69661c3))
* **get:** simplify symlink logic
([#1035](#1035))
([4f64307](4f64307)),
closes [#1030](#1030)
* **release-please-action:** do not point to manifest file
([96eeec8](96eeec8))
* **release-please-action:** point to config and manifest
([0a6a44d](0a6a44d))
* **release-please:** correct path to package
([3719cee](3719cee))
* **release-please:** remove manifest
([23a16fb](23a16fb))
* **run:** mark run mode as deprecated
([#1027](#1027))
([1115728](1115728))
* **test:** try adding chores to release notes
([#1031](#1031))
([5cabc20](5cabc20))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

This was referenced Feb 21, 2024

Merged

PR test coverage requirement #1041

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment