fix(core): update-swagger executor always reinstalls tool #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
AgentEnder
approved these changes
Sep 19, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Sep 20, 2023
# [1.23.0](v1.22.0...v1.23.0) (2023-09-20) ### Bug Fixes * **core:** add slash to use exact path ([#685](#685)) ([#687](#687)) ([1a87d83](1a87d83)) * **core:** codegen should not import self and default to required reference types ([#761](#761)) ([2310556](2310556)) * **core:** obey path in solution-file parameter when generating projects ([#762](#762)) ([29c234d](29c234d)) * **core:** support new name for enforce-module-boundaries eslint rule ([#742](#742)) ([24eb831](24eb831)) * **core:** update-swagger executor always reinstalls tool ([#757](#757)) ([63cf4b4](63cf4b4)) * **dotnet:** update args handling for dotnet format ([#678](#678)) ([772303e](772303e)) ### Features * **core:** add argument forwarding to dotnet new ([#722](#722)) ([cdc3654](cdc3654)) * **core:** make swagger tool run in project directory ([#758](#758)) ([12d89ac](12d89ac)) Sep 20, 2023, 3:59 PM
|
🎉 This PR is included in version 1.23.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
@all-contributors-bot add @EchelonFour for code and bugs |
|
@all-contributors add @EchelonFour for code and bugs |
|
I've put up a pull request to add @EchelonFour! 🎉 |
|
😓 I can never remember the name for the bot command, it doesn't autocomplete for some reason. Thanks again @EchelonFour |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code is written with the assumption that the tools manifest files looks like:
{ "version": 1, "isRoot": true, "tools": { "swashbuckle.aspnetcore.cli": "6.5.0" } }when it is actually
{ "version": 1, "isRoot": true, "tools": { "swashbuckle.aspnetcore.cli": { "version": "6.5.0", "commands": ["swagger"] } } }Also, the tool name is case insensitive.
So I wrote some util functions and interfaces to read the file in a type safe way.
The bug just caused you to reinstall the tool even though it was already installed.