Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project name in nx configuration file #13

Closed
Arcahub opened this issue Apr 5, 2022 · 3 comments
Closed

Project name in nx configuration file #13

Arcahub opened this issue Apr 5, 2022 · 3 comments
Labels
question Further information is requested

Comments

@Arcahub
Copy link

Arcahub commented Apr 5, 2022

Hello,

I'm starting to use your plugin to work on a multi language monorepo with rust, react and web assembly and its help a lot so thanks for this nice plugin.

I've a question about the name of the project in the nx configuration files. You chose to use snake case but most (all ?) of the plugin written by the @nrwl/nx team are using snake case with hyphen instead of underscore. I'm not really here to debate about the best way to name variable but it add a bit of inconsistency in the files of the monorepo.

So my request would be to change this behaviour to be the same as for @nrwl/nx.

I won't mind doing it myself in a pull request if you are willing to accept this change.

Regards,

Guillaume

@Arcahub
Copy link
Author

Arcahub commented Apr 8, 2022

I just saw that you commented about that in #7 . Did you have any thought about that small change ?

@dannymcgee
Copy link
Contributor

Hey @Arcahub, unfortunately I've been neglecting this poor project. >_< My intention is to fix this so that the plugin supports both kebab-case and snake_case projects without any issues. Unfortunately I haven't had the time to look into it yet. I will have a few days off next week, so I'll do my best to tackle it then. But if you'd like to take a crack at it in the meantime, please feel free!

@dannymcgee dannymcgee added the question Further information is requested label May 25, 2022
@dannymcgee
Copy link
Contributor

This was fixed in #16 and I forgot to close the issue — whoops. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants