-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request: save settings to share link #30
Comments
Maybe you could also save a version number in the URL and hardcode the default settings somewhere in the app, so when the link is opened, the app knows which "settings version" it should load. |
It would probably be beneficial if we were to store all the settings in one state dictionary variable, so we could easily serialize and deserialize all settings without having to go through each single setting variable on it's own. Alternatively we could also just forEach through all input elements. Maybe use a class like "settings-input" for that. |
Implemented basic functionality for this in Pull Request #36 Only changed settings are saved to the URL, but at this point it has no 'version control'. So as mentioned before, changing the default settings in the future can change the behavior of existing URLs. |
Included in the latest release, follow-up issues are #38. |
Currently when using the share sankey as link function only the content gets shared, not the settings. In the future the settings should also be included in the share link.
Attention: I think the share link should only include actually changed settings as that would help keeping the link length in check. The downside is that when we decide to change the default of some settings in the future, the settings would default on the new pre-set value.
The text was updated successfully, but these errors were encountered: