Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: save settings to share link #30

Closed
JonasDoesThings opened this issue Dec 15, 2021 · 5 comments · Fixed by #36
Closed

feature request: save settings to share link #30

JonasDoesThings opened this issue Dec 15, 2021 · 5 comments · Fixed by #36
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@JonasDoesThings
Copy link
Member

Currently when using the share sankey as link function only the content gets shared, not the settings. In the future the settings should also be included in the share link.

Attention: I think the share link should only include actually changed settings as that would help keeping the link length in check. The downside is that when we decide to change the default of some settings in the future, the settings would default on the new pre-set value.

@JonasDoesThings JonasDoesThings added enhancement New feature or request good first issue Good for newcomers help wanted labels Dec 15, 2021
@domvo
Copy link
Contributor

domvo commented Dec 19, 2021

Maybe you could also save a version number in the URL and hardcode the default settings somewhere in the app, so when the link is opened, the app knows which "settings version" it should load.

@JonasDoesThings
Copy link
Member Author

JonasDoesThings commented Oct 22, 2022

It would probably be beneficial if we were to store all the settings in one state dictionary variable, so we could easily serialize and deserialize all settings without having to go through each single setting variable on it's own.

Alternatively we could also just forEach through all input elements. Maybe use a class like "settings-input" for that.

@JonasDoesThings
Copy link
Member Author

Implemented basic functionality for this in Pull Request #36

Only changed settings are saved to the URL, but at this point it has no 'version control'. So as mentioned before, changing the default settings in the future can change the behavior of existing URLs.

@JonasDoesThings JonasDoesThings linked a pull request Oct 22, 2022 that will close this issue
@JonasDoesThings
Copy link
Member Author

Included in the latest release, follow-up issues are #38.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants