Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: feat(nanocl:state): add state logs command #552

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

anonkey
Copy link
Contributor

@anonkey anonkey commented Oct 5, 2023

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@anonkey anonkey changed the title feat(nanocl:state): add state logs command Draft: feat(nanocl:state): add state logs command Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (a88ba46) 47.98% compared to head (1013078) 48.50%.

Additional details and impacted files
@@             Coverage Diff             @@
##           nightly     #552      +/-   ##
===========================================
+ Coverage    47.98%   48.50%   +0.52%     
===========================================
  Files          172      172              
  Lines        13742    13820      +78     
===========================================
+ Hits          6594     6704     +110     
+ Misses        7148     7116      -32     
Flag Coverage Δ
unittests 48.50% <82.00%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
bin/nanocl/src/main.rs 70.14% <ø> (ø)
bin/nanocl/src/models/state.rs 35.29% <25.00%> (-3.17%) ⬇️
bin/nanocl/src/commands/state.rs 62.63% <84.37%> (+13.28%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anonkey anonkey force-pushed the feat/state-logs branch 3 times, most recently from 71f2726 to 2b2c278 Compare October 5, 2023 05:55
Copy link
Member

@leon3s leon3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@leon3s leon3s merged commit 5349a2f into nightly Oct 5, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants