Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/nanocld: add new send event to vm actions #559

Merged
merged 4 commits into from
Oct 7, 2023

Conversation

Joao-Moura
Copy link
Contributor

- What I did

  • Added new send event trigger for create/delete/fix/run/stop vm actions

- A picture of a cute animal (not mandatory but encouraged)
image

Signed-off-by: Joao-Moura <jaummoura15@gmail.com>
Signed-off-by: Joao-Moura <jaummoura15@gmail.com>
@Joao-Moura Joao-Moura marked this pull request as ready for review October 6, 2023 23:52
@leon3s
Copy link
Member

leon3s commented Oct 7, 2023

Looks good thanks!
Can you add a tests case please ? there are located in this file :
https://github.com/nxthat/nanocl/blob/5a38bde3ad64beff8116b93fe5b6e524498dabff/bin/nanocld/src/event.rs#L189

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (5a38bde) 48.50% compared to head (94405e3) 48.53%.

Additional details and impacted files
@@             Coverage Diff             @@
##           nightly     #559      +/-   ##
===========================================
+ Coverage    48.50%   48.53%   +0.03%     
===========================================
  Files          172      172              
  Lines        13818    13849      +31     
===========================================
+ Hits          6702     6722      +20     
- Misses        7116     7127      +11     
Flag Coverage Δ
unittests 48.53% <1.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
bin/nanocld/src/event.rs 76.41% <ø> (ø)
crates/nanocl_stubs/src/vm.rs 33.33% <100.00%> (+33.33%) ⬆️
bin/nanocld/src/utils/state.rs 47.36% <0.00%> (+0.18%) ⬆️
bin/nanocld/src/services/vm.rs 14.34% <0.00%> (ø)
crates/nanocl_stubs/src/system.rs 6.52% <0.00%> (-1.82%) ⬇️
bin/nanocld/src/utils/vm.rs 3.14% <0.00%> (-0.23%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Joao-Moura <jaummoura15@gmail.com>
Signed-off-by: Joao-Moura <jaummoura15@gmail.com>
Copy link
Member

@leon3s leon3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@leon3s leon3s merged commit 5e7e8bf into next-hat:nightly Oct 7, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants