Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/nanocld: before cargo #579

Merged
merged 3 commits into from
Oct 23, 2023
Merged

feature/nanocld: before cargo #579

merged 3 commits into from
Oct 23, 2023

Conversation

leon3s
Copy link
Member

@leon3s leon3s commented Oct 21, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (c2900e0) 48.78% compared to head (01071ea) 49.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           nightly     #579      +/-   ##
===========================================
+ Coverage    48.78%   49.00%   +0.22%     
===========================================
  Files          174      174              
  Lines        13576    13624      +48     
===========================================
+ Hits          6623     6677      +54     
+ Misses        6953     6947       -6     
Flag Coverage Δ
unittests 49.00% <48.14%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
bin/nanocl/src/commands/cargo.rs 61.74% <100.00%> (-0.13%) ⬇️
bin/nanocl/src/commands/state.rs 62.28% <ø> (-0.22%) ⬇️
bin/nanocld/src/models/cargo_config.rs 100.00% <100.00%> (ø)
bin/nanocld/src/models/http_metric.rs 0.00% <ø> (ø)
bin/nanocld/src/models/resource.rs 94.44% <ø> (ø)
bin/nanocld/src/models/vm.rs 9.09% <ø> (ø)
bin/nanocld/src/models/vm_config.rs 0.00% <ø> (ø)
bin/nanocld/src/repositories/generic.rs 100.00% <ø> (ø)
crates/nanocl_stubs/src/cargo_config.rs 65.00% <66.66%> (+0.13%) ⬆️
bin/nanocld/src/utils/cargo.rs 64.75% <44.89%> (-1.13%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leon3s leon3s merged commit fad68fa into nightly Oct 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant