Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks good. #1

Closed
soggybag opened this issue Sep 15, 2019 · 1 comment
Closed

Looks good. #1

soggybag opened this issue Sep 15, 2019 · 1 comment

Comments

@soggybag
Copy link

That flower is positioning the center with absolute position and a % left. This is going to make it change position if the window changes size! The % left will be equal to a % of the width of the window.

Better to use px here.

Better yet, wrap all of the flower parts in a div container and make that position: relative. Now all absolutely positioned descendants will calculate their position from the edges of this container.

@Nyapal
Copy link
Owner

Nyapal commented Oct 6, 2019

Refactored my code using flexbox and updated the class repo!

@Nyapal Nyapal closed this as completed Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants