Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken linkified URL #1863

Closed
orschiro opened this issue Apr 3, 2016 · 4 comments
Closed

Broken linkified URL #1863

orschiro opened this issue Apr 3, 2016 · 4 comments
Labels
bug

Comments

@orschiro
Copy link

orschiro commented Apr 3, 2016

Dear all,

The following URL is not properly linkified:

dev.tellform.com/#!/verify/xcFfUbvQL0FG298GsB0nBJGS7QRi7nsWVjS9iSyaeyBCFgUv

Thankfully,

~Robert

image
@mbilker
Copy link
Contributor

mbilker commented Apr 4, 2016

Thanks for the report @orschiro. What version of N1 are you running?

N1 replaced the Autolinker used in recent versions to (hopefully) fix issues like this one.

@orschiro
Copy link
Author

orschiro commented Apr 4, 2016

Thanks for your help, Matt!

That's great news.

I'm using version 0.4.19-d41e72c

Warmly,

~Robert

Sent from Nylas N1, the extensible, open source
mail client.

On Apr 4 2016, at 3:59 am, Matt Bilker <notifications@github.com> wrote:

Thanks for the report @orschiro. What version
of N1 are you running?

N1 replaced the Autolinker used in recent versions to (hopefully) fix issues
like this one.

—
You are receiving this because you were mentioned.
Reply to this email directly or [view it on GitHub](https://github.com/nylas/N
1/issues/1863#issuecomment-205102512)![](https://github.com/notifications/beac
on/AAKbwxjYjDwDj-RY2oDswkjOAd4e5RJhks5p0HBkgaJpZM4H-hXn.gif)

bengotow added a commit that referenced this issue Apr 6, 2016
@bengotow
fix(autolinker): Additional test case from #1863
15eafa7
mbilker added a commit to mbilker/N1 that referenced this issue Apr 7, 2016
@mbilker
Merge remote-tracking branch 'github/master'
c8a073d 
* github/master:
  fix(search): Escape search query properly
  fix(contact-sidebar): Don't render <select> when no contacts available
  feat(thread-search): Make thread search indexing smarter
  lint(*): Fix linter errors from QA fixes
  fix(fwd): Do not mention Bcc'd recipeints in forward headers nylas#1873
  fix(autolinker): Additional test case from nylas#1863
  fix(autolinker): Add test cases, .ly, url hash chars
  fix(scheduler): can scheduler on 30 min intervals
  fix(scheduler): removes proposals from metadata when removing event
  fix(scheduler): can remove proposed times
  fix(scheduler): fix time bar scroll height
  fix(calendar): today correctly jumps to this week
  fix(scheduler): fix top banner
  fix(cc/bcc): Make targets bigger, wait longer before declaring focus left
  fix(composer): Do not steal focus when it is in other components
  🎨(preferences): Update styling
  fix(*): Minor CSS fixes, open tracking fix when only message is draft
  fix(error): Show actual API domain in connection error bar
  fix(composer-emoji): Fix tabs to scroll correctly
  fix(schedule): extracted to own SyncbackDraftEventsTask
@bengotow
Copy link
Contributor

Hey folks! This has shipped in 0.4.25, which will be hitting the auto-updaters soon. (If you want you can grab the update now on the Releases page.) Give it a spin, and feel free to re-open if you run into the issue again. Cheers—enjoy the update!

@orschiro
Copy link
Author

Dear @bengotow,

This problem still persists for me in version 0.4.25 with links that contain :.

See this example:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@orschiro @bengotow @mbilker