-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad Request when update the event #470
Comments
the sdk should omit the event.visibility when sending the update request. |
@ianzone have you tried specifying 'null' as default, does that work for you? |
There is always a remedial measure, but my point is the SDK should do the job as the docs described. |
Thanks for raising this point @ianzone. I have just reproduced the issue and we'll be looking to fix this. Thank you for reporting it! |
approach to fix: Need to ensure to nullify visibility before sending the payload if visibility is an empty string |
Closes #470, fixes the issue "Bad Request: Visibility cannot have the value ''".
# Changelog * Add support for logging (#508, #456) * Nullify replyToMessageId is an empty string (#484, #509) * Nullify visibility if visibility is an empty string (#507, #470) * Fix numbers defaulting to 0 instead of null (#469) * Fix parsing of Number arrays (#503, #502) * Fix configured timeout not being used (#506, #489) * Bump `node-fetch` dependency from 2.6.1 to 2.6.12 (#504, #496)
Source code
Error msg
Bad Request: Visibility cannot have the value ''
The text was updated successfully, but these errors were encountered: