Fixing an issue with Attirbute.Number transforming null values into 0 #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #469 +/- ##
=======================================
Coverage 91.70% 91.70%
=======================================
Files 62 62
Lines 2641 2641
Branches 481 481
=======================================
Hits 2422 2422
Misses 218 218
Partials 1 1
|
Merged
mrashed-dev
added a commit
that referenced
this pull request
Nov 29, 2023
# Changelog * Add support for logging (#508, #456) * Nullify replyToMessageId is an empty string (#484, #509) * Nullify visibility if visibility is an empty string (#507, #470) * Fix numbers defaulting to 0 instead of null (#469) * Fix parsing of Number arrays (#503, #502) * Fix configured timeout not being used (#506, #489) * Bump `node-fetch` dependency from 2.6.1 to 2.6.12 (#504, #496)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a bug that caused null values to return 0 for Attribute.Number. This will check if the value is null or not and return only if it's a valid Numbrer. This will avoid Number(null) returning 0.