Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout is always 150ms #489

Closed
kgtupelo opened this issue Oct 5, 2023 · 2 comments · Fixed by #506
Closed

Timeout is always 150ms #489

kgtupelo opened this issue Oct 5, 2023 · 2 comments · Fixed by #506
Labels

Comments

@kgtupelo
Copy link

kgtupelo commented Oct 5, 2023

Describe the bug
The provided timeout is not respected. When providing a timeout, it is always defaulting to 150ms.

if (config.timeout && config.timeout !== 0) {
controller = new AbortController();
timeout = setTimeout(() => {
controller.abort();
}, 150);
}

Expected behavior
The timeout we provide to be respected.

SDK Version:
6.10.0

@Siddikpatel
Copy link
Contributor

Hi. Can you check the PR #490 ? It seems to fix your issue.

@mrashed-dev
Copy link
Collaborator

Hey @kgtupelo, sorry to see that PR closed. I opened a new PR and the fix will be included in the next release. Apologies for the delay.

mrashed-dev added a commit that referenced this issue Nov 29, 2023
# Changelog
* Add support for logging (#508, #456)
* Nullify replyToMessageId is an empty string (#484, #509)
* Nullify visibility if visibility is an empty string (#507, #470)
* Fix numbers defaulting to 0 instead of null (#469)
* Fix parsing of Number arrays (#503, #502)
* Fix configured timeout not being used (#506, #489)
* Bump `node-fetch` dependency from 2.6.1 to 2.6.12 (#504, #496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants