Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return type for send RSVP #556

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

mrashed-dev
Copy link
Collaborator

@mrashed-dev mrashed-dev commented Apr 15, 2024

Description

Send RSVP used to just return a request_id in the response, now it can return an error object in the event of a partial success where the send RSVP request is executed but the email was not sent.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Copy link

@ozsivanov ozsivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrashed-dev mrashed-dev merged commit 30b8060 into main Apr 15, 2024
4 checks passed
@mrashed-dev mrashed-dev deleted the TW-2869-node-add-send-rsvp-response-type branch April 15, 2024 20:19
@mrashed-dev mrashed-dev mentioned this pull request Apr 15, 2024
mrashed-dev added a commit that referenced this pull request Apr 15, 2024
# Changelog
* Add response type to `sendRsvp` (#556)
* Add support for adding custom headers to outgoing requests (#552)
* Add support for custom headers field for drafts and messages (#553)
* Add support for setting `include_grant_scopes` for auth url generation (#554)
* Rename incorrect `type` field in `When` models to `object` (#551)
* Fix inaccuracy in `ReminderOverride` model (#555)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants