-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for passing in headers to outgoing calls #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronDDM
reviewed
Apr 5, 2024
AaronDDM
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test for some of the local overrides as well? Looks like we just have a test for the header being set at the top level.
@AaronDDM good callout, tests added. |
mrashed-dev
added a commit
that referenced
this pull request
Apr 8, 2024
This PR adds support to the custom headers field used to attach headers to message and draft objects. Not to be confused with custom headers to Nylas API requests, completed by #552.
Merged
mrashed-dev
added a commit
that referenced
this pull request
Apr 15, 2024
# Changelog * Add response type to `sendRsvp` (#556) * Add support for adding custom headers to outgoing requests (#552) * Add support for custom headers field for drafts and messages (#553) * Add support for setting `include_grant_scopes` for auth url generation (#554) * Rename incorrect `type` field in `When` models to `object` (#551) * Fix inaccuracy in `ReminderOverride` model (#555)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows you to pass in a map of additional, custom headers that can be sent to the Node SDK.
Usage
This can be used one of two ways, for all outgoing calls or on a per-call-basis.
All Calls
For all outgoing calls, you can set headers when initializing the Nylas SDK:
Per-call basis
For all calls to the API, we have an
override
object. This object is now extended to include aheaders
field.License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.