Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for include_grant_scopes=false on auth url generation #554

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

Taha-Sardar
Copy link
Contributor

Add support for include_grant_scopes=false on auth url generation. Currently include grant scopes is true by default and is not set to false if the user sets the variable as false - This fix should enable the user to do so

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@ashryanbeats
Copy link

Thanks for submitting @Taha-Sardar! I've requested the team to have a look.

Copy link
Collaborator

@mrashed-dev mrashed-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @Taha-Sardar! I'll fix the linting issue and merge, will be included in the next release.

@mrashed-dev mrashed-dev merged commit ef5af1e into nylas:main Apr 12, 2024
3 of 4 checks passed
@mrashed-dev mrashed-dev mentioned this pull request Apr 15, 2024
mrashed-dev added a commit that referenced this pull request Apr 15, 2024
# Changelog
* Add response type to `sendRsvp` (#556)
* Add support for adding custom headers to outgoing requests (#552)
* Add support for custom headers field for drafts and messages (#553)
* Add support for setting `include_grant_scopes` for auth url generation (#554)
* Rename incorrect `type` field in `When` models to `object` (#551)
* Fix inaccuracy in `ReminderOverride` model (#555)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants