preload schemas #363
preload schemas #363
Conversation
| name: name, | ||
| schema: schema.getSchema(files.getComponentPath(name)) | ||
| }; | ||
| })); |
There was a problem hiding this comment.
Is kiln the only component interested in this data? I am wondering how this will affect page-load performance, as it increases the size of the state object. Perhaps there could be another end-point to return all the schemas which kiln could call.
There was a problem hiding this comment.
Hmm. It does increase the size of the state object, but not by a super huge amount. Alternatively, we could give a list of filepaths rather than loading the files, but that would require some odd kiln workarounds.
| if (fs.existsSync(path.join(dir, 'schema.yml'))) { | ||
| return path.join(dir, 'schema.yml'); | ||
| } else if (fs.existsSync(path.join(dir, 'schema.yaml'))) { | ||
| return path.join(dir, 'schema.yaml'); |
There was a problem hiding this comment.
Minor possible tweak: 'schema.yml' and 'schema.yaml' could be const at top.
| @@ -94,6 +96,12 @@ function applyOptions(options, res) { | |||
|
|
|||
| // can't assign to result, or we'd get a circular reference in refs. | |||
| _.set(state, '_components', componentList); | |||
| _.set(state, '_componentSchemas', _.map(componentList, function (name) { | |||
There was a problem hiding this comment.
Eh, I think this is better because they're not just an array of path strings (but rather objects with some properties)
_componentSchemasstate property so they can be used by templates