Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kiln plugins #553

Merged
merged 8 commits into from
Aug 4, 2016
Merged

kiln plugins #553

merged 8 commits into from
Aug 4, 2016

Conversation

nelsonpecora
Copy link
Contributor

  • fixes proposal: kiln plugins #540
  • adds window.kiln.plugins object (and service)
  • adds window.kiln events (see readme)
  • exposes certain services in window.kiln.services

* `unpublish`
* `select` - after a component is selected
* `unselect`
* `add-selector` - after a selector is added to a component
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a good idea to describe the event data associated with the event?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll do this later when the system has been tested.

@jonwinton
Copy link
Contributor

👍

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 79.985% when pulling da517c3 on plugins into bcfe4f0 on master.

@nelsonpecora nelsonpecora merged commit 1009c72 into master Aug 4, 2016
@nelsonpecora nelsonpecora deleted the plugins branch August 4, 2016 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: kiln plugins
3 participants