Jedrzej/bugfix/historical uptimes recording #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstuczyn
requested review from
durch,
futurechimp,
neacsu and
octol
as code owners
jstuczyn
force-pushed
the
jedrzej/bugfix/historical-uptimes-recording
branch
from
6bce1d2
to
96270b2
Compare
jstuczyn
force-pushed
the
release/v1.1.0
branch
from
026c314
to
fb1649b
Compare
jstuczyn
force-pushed
the
jedrzej/bugfix/historical-uptimes-recording
branch
from
96270b2
to
2094342
Compare
jstuczyn
force-pushed
the
jedrzej/bugfix/historical-uptimes-recording
branch
from
fa0afdb
to
75f3b65
Compare
jstuczyn
force-pushed
the
jedrzej/bugfix/historical-uptimes-recording
branch
from
75f3b65
to
43d8eec
Compare
fmtabbara
pushed a commit
that referenced
this pull request
Oct 31, 2022
* Removed commented out type alias * typos * Using the same underlying timer for uptime updater * Updating uptimes at 23:00 UTC each day * Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1942
Due to incorrectly used futures when shutdown was introduced, validator-api would fail to trigger any subsequent runs of the historical uptime updates; this PR fixes it + makes uptime happen at constant, predictable time as opposed to being based on when the binary was started
Checklist:
CHANGELOG.md