-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix: Network Explorer: Add freegeoip API key and split out tasks for country distributions #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstuczyn
requested changes
Oct 7, 2021
jstuczyn
approved these changes
Oct 8, 2021
e9d5cf7
to
ceeaa46
Compare
…and get data from the location cache
…have locations or ones where the cache TTL has expired
68c423a
to
592e52b
Compare
durch
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes up a bug in the country distribution tasks and hopefully improves the code structure by splitting out the tasks more.
Error
types to the locationResult
to log when the explorer-api is being rate limited by freegoip and also when a mix node's IP address cannot be located (there are a few that can't be found)Things that could be improved / ideas / concerns:
for (...) { ... return; }
pattern (a throw back to my C++ days)I am much happier with the location task picking things off every 50ms because it works better with the naive way we spawn tokio tasks. The service will actually stop now when a halt signal is sent.