Fix path for github action running tauri-wallet-tests #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
. Applied prettier to the code base . Removed delegation to gateway tests
durch
approved these changes
Nov 11, 2021
fmtabbara
approved these changes
Nov 11, 2021
mmsinclair
reviewed
Nov 11, 2021
| @@ -0,0 +1 @@ | |||
| {} | |||
There was a problem hiding this comment.
Are you sure this should be an empty config?
Also, be careful only using prettier because the root of the project has eslint (and no prettier). They will end up flip-flopping unless configured to work together. Look at https://prettier.io/docs/en/integrating-with-linters.html and use https://github.com/prettier/eslint-plugin-prettier to drive prettier.
I'm wondering if we should maybe do that work in another PR? Because it will likely mean a lot of formatting changes to the wallet JS/TS code.
mmsinclair
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
. Applied prettier to the code base
. Removed delegation to gateway tests
. Add future tasks in product board for TS, And unbonding nodes / gateways.