Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert inside insert (Firefox and Webkit) #41

Closed
johanneswilm opened this issue Jan 15, 2013 · 4 comments
Closed

insert inside insert (Firefox and Webkit) #41

johanneswilm opened this issue Jan 15, 2013 · 4 comments

Comments

@johanneswilm
Copy link
Contributor

How to reproduce:

  1. Go to http://nytimes.github.com/ice/demo/
  2. In the first example, scroll down to the paragraph that starts "As a member of the 1%" (in green).
  3. Put the cursor at the end of above mentioned paragraph.
  4. Hit "enter" to start a new paragraph.
  5. Write something
  6. Check the DOM structure of the paragraph you wrote in 5: It will have an "insert" inside an "insert" with the outer insert representing the author from the paragraph above.

Reproduceable in both Webkit and Firefox, with and without TinyMCE plugin version

@delambo
Copy link
Member

delambo commented Jan 16, 2013

I think this is a problem with the browser/contenteditable, not ice. Tinymce and other web editors do a better job of preventing this problem, which is why I always recommend using ice with tinymce (and any other editor that it will play nice in).

@delambo delambo closed this as completed Jan 16, 2013
@johanneswilm
Copy link
Contributor Author

well, it is an error in the demo you guys have running on the site, and the error is present in both Firefox and Webkit, which seems pretty serious. I will figure out whether this does or doesn't apply in the TinyMCE version.

I really think you guys should remove the claim that this works in Chrome or outside of TinyMCE until it really does.

@johanneswilm
Copy link
Contributor Author

I tried it out in Firefox 18 with the TinyMCE plugin demo -- the same thing happens except that the outert ins is an insert-element and the inner ins-element is a span element, so please reopen!

@johanneswilm
Copy link
Contributor Author

fixed in johanneswilm@150db9f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants