-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easy way to disable css module support #243
Comments
Thanks for your feedback! I wanted to clarify a one thing about your setup to see how we could best adjust the documentation. Do your current react components import css files or are you using inline styles? Would you mind sharing how you disabled CSS modules? |
I import sass files which doesn't play very well with CSS modules. Here's snippets from the webpack config I use to override module support:
|
Hey @lawlmart, thanks for the info! We're gonna take a good look at this and get back to you. |
@ccpricenytimes Ok, I'm realizing my hacky solution is going to break every time there's a major upgrade. If I create a PR with a "enableCSSModules" option in the kyt.config would you be amenable to merging it in? Seems like a win since it's one less convention people will need to follow. |
Hey @lawlmart |
@lawlmart’s solution is great, I’m using a similar hack. It appears that there’s still no proper way to supply custom arguments to webpack loaders in kyt (for example, |
First off - thanks for this! I just finished porting a project from create-react-app and I'd say overall it wasn't a terrible experience. One thought: my react components weren't designed with css modules in mind and it took me far too long to figure out what was happening and how to disable it (I'm new to the magical world of Babel+Webpack). Take it or leave it, but a config option to directly alter the root CSS loader would be nice - or at least more documentation on the trade-offs of using modules.
The text was updated successfully, but these errors were encountered: