-
Notifications
You must be signed in to change notification settings - Fork 195
Conversation
I think I can do it, just did not think of it when playing around. |
Great, BTW, the current trend is to use rectangular boxes (instead of rounded) for search boxes. If that helps to put the menu button there you may do that change too. Only with very small round radius, like the toolbar buttons. This search box is used on all tabs (downloads, history, messages, settings). Don't write code to hide the menu button on other tabs, we'll make it useful on all tabs later. |
Something like this, obviously still work to to, just look at the idea. history/message/settings is wrong, think the controls get hidden by the fasttable class, have not looked too closely yet. |
Some interesting things that users probably do not know (seeing it in the code) BTW this search terms only orks if refresh is active, have not looked at how to immediately refresh like the Clear button |
When clicking the search box search terms will be show. Don't know if the caret is really nessary since it just takes up space. Beginning to understand the source base.
Good progress here 👍 Suggestions:
For the future improvements: instead of hard coding the search terms I would implement an ability for users to alter the menu. The last three menu items would be: save search, remove search and remove all; These are the only menu items the user sees when using the menu the first time. The search menu should be saved per tab (download, history, etc.). This is however the second todo. First is to finish the UI - hard coded items are OK for that phase. Another note: the UI has two modes: desktop and phone. If you make the browser window small enough you'll see how the phone mode activates. In this mode many UI elements are shown differently. Most of this is done via extra CSS formatting. Sometimes javascript is involved too. When doing changes to UI don't forget to checked the phone mode too. Thank you for your contribution. |
Looks like you've the lost the interest for this feature. After implementing of advanced search in #72 the predefined search terms would be even more useful. This PR however conflicts with current develop branch and it also contains experimental code (different versions) which is bad for commit history. If you still interested in this feature please feel free to open a clean PR based on current develop branch. Before working on it please let me know about that because I may start implementing this myself as explained in my previous post - #40 (comment). |
Hi Andrey |
Suggestion for predefined search terms.
Todo:
search icon needed (used the config icon for demonstration)
letting user define terms in config file (do not know if this is needed/wanted)
PP-Queued should also be added to active list.
Boolean implementation was improved.