Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

Predefined search terms #40

Closed
wants to merge 12 commits into from
Closed

Predefined search terms #40

wants to merge 12 commits into from

Conversation

teonar
Copy link
Contributor

@teonar teonar commented Jun 27, 2015

Suggestion for predefined search terms.

Todo:
search icon needed (used the config icon for demonstration)
letting user define terms in config file (do not know if this is needed/wanted)

PP-Queued should also be added to active list.
Boolean implementation was improved.

@hugbug
Copy link
Member

hugbug commented Jun 27, 2015

Instead of the new button the menu should be integrated into the search box:

screen shot 2015-06-27 at 19 29 00

Doable?

@teonar
Copy link
Contributor Author

teonar commented Jun 27, 2015

I think I can do it, just did not think of it when playing around.

@hugbug
Copy link
Member

hugbug commented Jun 27, 2015

Great,

BTW, the current trend is to use rectangular boxes (instead of rounded) for search boxes. If that helps to put the menu button there you may do that change too. Only with very small round radius, like the toolbar buttons.

This search box is used on all tabs (downloads, history, messages, settings). Don't write code to hide the menu button on other tabs, we'll make it useful on all tabs later.

@teonar
Copy link
Contributor Author

teonar commented Jun 27, 2015

Something like this, obviously still work to to, just look at the idea.

history/message/settings is wrong, think the controls get hidden by the fasttable class, have not looked too closely yet.

@teonar
Copy link
Contributor Author

teonar commented Jun 27, 2015

Some interesting things that users probably do not know (seeing it in the code)
e.g. pressing Enter make the search case sensitive

BTW this search terms only orks if refresh is active, have not looked at how to immediately refresh like the Clear button

teonar added 4 commits June 27, 2015 23:08
When clicking the search box search terms will be show. Don't know if
the caret is really nessary since it just takes up space.

Beginning to understand the source base.
@hugbug
Copy link
Member

hugbug commented Jun 28, 2015

Good progress here 👍

Suggestions:

  • the menu should not be shown when the edit box is clicked. The menus typically shown in such cases are for autocomplete, which isn't our case;

  • therefore we do need the arrow (caret) icon which will trigger the menu; Once again the GitHub's issue search box as an example (the "Filters"-menu):

    screen shot 2015-06-28 at 18 16 57

    We don't have that much space to add a text, a small icons is enough.

  • current implementation doesn't work on Firefox - a click on the search box opens the menu but doesn't set focus to the edit box, the search box isn't usable therefore. I think this problem will be automatically fixed when the previous issue is solved.

For the future improvements: instead of hard coding the search terms I would implement an ability for users to alter the menu. The last three menu items would be: save search, remove search and remove all; These are the only menu items the user sees when using the menu the first time. The search menu should be saved per tab (download, history, etc.). This is however the second todo. First is to finish the UI - hard coded items are OK for that phase.

Another note: the UI has two modes: desktop and phone. If you make the browser window small enough you'll see how the phone mode activates. In this mode many UI elements are shown differently. Most of this is done via extra CSS formatting. Sometimes javascript is involved too. When doing changes to UI don't forget to checked the phone mode too.

Thank you for your contribution.

@hugbug
Copy link
Member

hugbug commented Aug 18, 2015

Looks like you've the lost the interest for this feature.

After implementing of advanced search in #72 the predefined search terms would be even more useful.

This PR however conflicts with current develop branch and it also contains experimental code (different versions) which is bad for commit history.

If you still interested in this feature please feel free to open a clean PR based on current develop branch. Before working on it please let me know about that because I may start implementing this myself as explained in my previous post - #40 (comment).

@hugbug hugbug closed this Aug 18, 2015
@teonar
Copy link
Contributor Author

teonar commented Aug 18, 2015

Hi Andrey
Have not lost interest, Had a burglary at my home and my stuff was taken, still trying to get everything back to what it was.No idea when I will be able to do anything, probably 3 weeks or more.
RegardsT

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants