Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

Fixing LGTM alerts #605

Closed
wants to merge 1 commit into from
Closed

Fixing LGTM alerts #605

wants to merge 1 commit into from

Conversation

hugbug
Copy link
Member

@hugbug hugbug commented Jan 17, 2019

This PR is to test LGTM integration. See #604.

@hugbug hugbug added the meta label Jan 17, 2019
@hugbug hugbug changed the title Exclude third-party files from LGTM analysis Fixing LGTM alerts Jan 18, 2019
@hugbug hugbug force-pushed the 604-lgtm branch 2 times, most recently from a7573a7 to 017bf3d Compare January 19, 2019 10:28
@hugbug
Copy link
Member Author

hugbug commented Jan 19, 2019

This pull request fixes 52 alerts when merging 017bf3d into 6bf097f - view on LGTM.com

fixed alerts:

  • 25 for Unused variable, import, function or class
  • 6 for Expression has no effect
  • 5 for Superfluous trailing arguments
  • 5 for Duplicate character in character class
  • 3 for Comparison result is always the same
  • 2 for Declaration hides parameter
  • 1 for Useless assignment to local variable
  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
  • 1 for Wrong type of arguments to formatting function
  • 1 for Virtual call from constructor or destructor
  • 1 for Conflicting HTML element attributes
  • 1 for Ambiguous HTML id attribute

Comment posted by LGTM.com

@hugbug hugbug reopened this Jan 19, 2019
@hugbug hugbug closed this Feb 9, 2019
@hugbug hugbug deleted the 604-lgtm branch February 9, 2019 18:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant