Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does subsribe take fetch but ubsubscribe takes authenticatedFetch? #3

Open
ianconsolata opened this issue Feb 1, 2023 · 1 comment

Comments

@ianconsolata
Copy link

In most Solid libraries, passing an authenticated fetch function commonly uses the fetch parameter. For both internal consistency and aligning with the convention of other libraries, I think the parameter passed to unsubscribe should also be called fetch. If there is a good reason that unsubscribe renames the parameter, it would be helpful if that was documented in lib/unsubscribe.

@jaxoncreed
Copy link
Contributor

jaxoncreed commented Feb 7, 2023

I'll note this for an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants