You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In most Solid libraries, passing an authenticated fetch function commonly uses the fetch parameter. For both internal consistency and aligning with the convention of other libraries, I think the parameter passed to unsubscribe should also be called fetch. If there is a good reason that unsubscribe renames the parameter, it would be helpful if that was documented in lib/unsubscribe.
The text was updated successfully, but these errors were encountered:
In most Solid libraries, passing an authenticated fetch function commonly uses the
fetch
parameter. For both internal consistency and aligning with the convention of other libraries, I think the parameter passed tounsubscribe
should also be calledfetch
. If there is a good reason thatunsubscribe
renames the parameter, it would be helpful if that was documented inlib/unsubscribe
.The text was updated successfully, but these errors were encountered: