Move Field to JS #12
Merged
Move Field to JS #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitschabaude
force-pushed
the
refactor/field
branch
from
95a61f1
to
d18a305
Compare
Trivo25
approved these changes
May 30, 2023
bkase
requested changes
May 30, 2023
ocaml/lib/snarky_js_bindings_lib.ml
Outdated
| does 16 bits per row (vs 1 bits per row that you can do with generic gates). | ||
| [length] has to be a multiple of 16 | ||
| *) | ||
| let truncate_to_bits (length : int) x = |
There was a problem hiding this comment.
can we make this parameter length_div_16 instead and multiply by 16 in the body of the function -- then the function is total and the caller can prove that it's a multiple of 16 by dividing it by 16 before passing it in.
Consider changing the name to truncate_to_bits16 also
There was a problem hiding this comment.
the input length is a plain integer, which will define the circuit statically, so the caller can't / doesn't have to prove anything about it.
do you still think we should change the signature?
I'm going to change it here but not in the user-facing SnarkyJS method for now (but will throw a quick error there)
bkase
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes snarky methods on field elements, in service of o1-labs/o1js#902