-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Field to JS #12
Merged
Merged
Move Field to JS #12
Changes from 16 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
f3bee67
Merge branch 'refactor/js-circuit' into refactor/field
mitschabaude fe3fb48
fixup
mitschabaude e3c2adf
fix import
mitschabaude e6a0f85
import fix
mitschabaude 4bd8a30
Merge branch 'main' into refactor/field
mitschabaude 09a0961
add lower level field module
mitschabaude 127140c
field
mitschabaude 6feb93d
minor
mitschabaude c6d7052
more efficient exists, rename r1cs
mitschabaude b7a3b7a
lower level exists
mitschabaude 899c2f4
make to/from bits operate on array
mitschabaude ea9e323
fixup
mitschabaude d18a305
update bindings
mitschabaude b38c12c
expose more assert methods, for constraint equivalence in js
mitschabaude acb0b31
update bindings
mitschabaude 29bf1c6
Merge branch 'main' into refactor/field
mitschabaude 6f1d1b0
address feedback
mitschabaude d38acc5
update bindings
mitschabaude 371efb5
Merge branch 'main' into refactor/field
mitschabaude File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
183,124 changes: 91,764 additions & 91,360 deletions
183,124
compiled/node_bindings/snarky_js_node.bc.cjs
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we make this parameter
length_div_16
instead and multiply by 16 in the body of the function -- then the function is total and the caller can prove that it's a multiple of 16 by dividing it by 16 before passing it in.Consider changing the name to
truncate_to_bits16
alsoThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the input length is a plain integer, which will define the circuit statically, so the caller can't / doesn't have to prove anything about it.
do you still think we should change the signature?
I'm going to change it here but not in the user-facing SnarkyJS method for now (but will throw a quick error there)