Fix stack overflow for large witnesses #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitschabaude
commented
Dec 18, 2023
Comment on lines
+7
to
+13
| function caml_wrap_exception(e) { | ||
| if (e instanceof Array) return e; | ||
| if (e instanceof globalThis.Error && caml_named_value('jsError')) | ||
| return [0, caml_named_value('jsError'), e]; | ||
| //fallback: wrapped in Failure | ||
| return [0, caml_global_data.Failure, caml_string_of_jsstring(String(e))]; | ||
| } |
There was a problem hiding this comment.
this fixes that stack overflows used to be thrown as an array. it overrides the caml_wrap_exception function from JSOO, which has a special case for stack overflows, which doesn't preserve the stack trace.
this simply removes the special case, and thus stack overflows end up in the second if case, where we preserve the original error e which can be later be re-thrown in JS.
| } | ||
|
|
||
| let typ (size_in_field_elements : int) : (Field.t array, field array) Typ.t = | ||
| Typ { empty_typ with size_in_field_elements } |
There was a problem hiding this comment.
the original implementation using Typ.array was causing stack overflows in (at least) the check function, because it operated on an OCaml list with a recursive function
Trivo25
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
companion for o1-labs/o1js#1334