Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stack overflow for large witnesses #1334

Merged
merged 7 commits into from
Dec 18, 2023
Merged

Fix stack overflow for large witnesses #1334

merged 7 commits into from
Dec 18, 2023

Conversation

mitschabaude
Copy link
Member

@mitschabaude mitschabaude commented Dec 18, 2023 •
edited
Loading

fixes #738
fixes #144
fixes #147
fixes #1210

  • fixes the stack overflows in all of the issues above, by using better snarky provable type for field arrays. see bindings PR
  • adds two regression tests which capture the issues above
  • I manually tested the code reproductions provided in 3 of those issues and confirmed that they all work now

bindings: o1-labs/o1js-bindings#224

@mitschabaude mitschabaude mentioned this pull request Dec 18, 2023
Merged
@mitschabaude mitschabaude merged commit b820dea into main Dec 18, 2023
13 checks passed
@mitschabaude mitschabaude deleted the fix/stack-overflow branch December 18, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trivo25 Trivo25 Trivo25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mitschabaude @Trivo25