New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle missing extended provable methods #273

Merged

mitschabaude merged 2 commits into main from fix/empty

May 16, 2024

Member

mitschabaude commented May 16, 2024 •

edited

Loading

companion of o1-labs/o1js#1657

when trying to compute empty(), toJSON() or fromJSON() on a provable that is missing it, throw an error instead of continuing to recurse into its properties (which just produces garbage)
some internal refactors of provable() to clean it up and make the logic mostly type-safe

mitschabaude added 2 commits

May 16, 2024 12:40


          gracefully handle non-existing extended provable methods

4ac4a80


          cleanup provable type deriver and make it internally type-safe

55481e7

Trivo25 approved these changes

View reviewed changes

mitschabaude merged commit ceda064 into main

1 check passed

mitschabaude deleted the fix/empty branch

May 16, 2024 15:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment