Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle missing extended provable methods #1657

Merged
merged 4 commits into from
May 16, 2024
Merged

Handle missing extended provable methods #1657

merged 4 commits into from
May 16, 2024

Conversation

mitschabaude
Copy link
Member

@mitschabaude mitschabaude commented May 16, 2024 •
edited

fixes #1656

  • add missing empty() methods on Group and Scalar
  • in bindings: properly handle the case of a missing empty() method
  • cover empty() behaviour in unit test

@mitschabaude mitschabaude mentioned this pull request May 16, 2024
Merged
@mitschabaude mitschabaude merged commit 8cf3b08 into main May 16, 2024
12 checks passed
@mitschabaude mitschabaude deleted the fix/empty branch May 16, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trivo25 Trivo25 Trivo25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proper handling of Struct.empty() when one of the base types doesn't have empty()
2 participants
@mitschabaude @Trivo25