Fix Wasm build DEVELOP #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use logger.fake
Move Field to JS
Improve stack traces
Remove duplicate user command fields
While this should be redundant, it is not in my experience. Though I had the execution permission set, my system did not want to execute this script. It is not clear to me why, since the error would only say "file not found", hence I opted for this simple workaround.
On NixOS, /bin/bash isn't available, only /bin/sh is.
Prepend /bin/sh when running dump-test-vectors.sh
Adapt global slot serialization
This reverts commit 8366852.
mrmr1993
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merges main + berkeley -> develop as a side effect of bringing the wasm fix MinaProtocol/mina#13341 to develop